sonic-swss
sonic-swss copied to clipboard
sonic-net
Attribute values changed for Zero Buffer Profile
Hi, While I understand the motivation behind the buffer pool changes, the commit message does not mention anything about why the zero buffer profile attribute values have been changed. For example, the SAI_BUFFER_PROFILE_ATTR_THRESHOLD_MODE attribute value was set to SAI_BUFFER_PROFILE_THRESHOLD_MODE_DYNAMIC with the threshold SAI_BUFFER_PROFILE_ATTR_SHARED_DYNAMIC_TH being programmed as '-8' for zero buffer profile. Why has this been changed now?
Originally posted by @svsivm in https://github.com/Azure/sonic-swss/issues/2185#issuecomment-1148357923
The change brought in by the PR #2185 (specifically the change in attribute values for the zero buffer profile) breaks the pfcwd behavior on certain platforms that use zero buffer profile. While making these changes, can we run the tests on all the impacted platforms before merging?