sonic-swss icon indicating copy to clipboard operation
sonic-swss copied to clipboard

Published 20 hours ago • verified publisher icon sonic-net

Don't query buffer profile attributes before APPLY_VIEW

Open kcudnik opened this issue 3 years ago • 7 comments

Change required to not query SAI_QUEUE_ATTR_BUFFER_PROFILE_ID and SAI_INGRESS_PRIORITY_GROUP_ATTR_BUFFER_PROFILE before APPLY_VIEW, because in warm boot scenario is bringing previous buffer profile into OA scope, and this is causing extra buffer profile to be created in syncd.

Issue in depth is described here: https://github.com/Azure/sonic-sairedis/issues/1030#issuecomment-1094077178

kcudnik avatar Apr 16 '22 07:04 kcudnik

Hello, do we have any update on this one? Thanks!

svsivm avatar Jun 09 '22 09:06 svsivm

@prsunny ping

kcudnik avatar Jun 09 '22 12:06 kcudnik

I see the original issue refers to zero-buffer pools. A related change is here - https://github.com/Azure/sonic-swss/pull/2304. @neethajohn , @stephenxs , can you check if its related?

prsunny avatar Jun 09 '22 20:06 prsunny

I see the original issue refers to zero-buffer pools. A related change is here - #2304. @neethajohn , @stephenxs , can you check if its related?

I’ll check it. Originally the purpose was to share the zero buffer profile by PFCWD with the existing one. Now that we will not apply zero buffer profile on ingress side, this change is not required

stephenxs avatar Jun 10 '22 00:06 stephenxs

#2304

Hi, I doubt if this problem has anything to do with #2304. #2231 is seen specifically when warmboot is done while PFC storm is ongoing. After warmboot we see 4 zero buffer profiles instead of the expected and that throws things into disarray.

svsivm avatar Jun 10 '22 05:06 svsivm

I see the original issue refers to zero-buffer pools. A related change is here - #2304. @neethajohn , @stephenxs , can you check if its related?

I’ll check it. Originally the purpose was to share the zero buffer profile by PFCWD with the existing one. Now that we will not apply zero buffer profile on ingress side, this change is not required

Hi Stephen, can you please look at #2319. Why were the zero buffer profile attribute values changed as part of #2185? Thanks.

svsivm avatar Jun 10 '22 05:06 svsivm

I see the original issue refers to zero-buffer pools. A related change is here - #2304. @neethajohn , @stephenxs , can you check if its related?

I’ll check it. Originally the purpose was to share the zero buffer profile by PFCWD with the existing one. Now that we will not apply zero buffer profile on ingress side, this change is not required

Hi Stephen, can you please look at #2319. Why were the zero buffer profile attribute values changed as part of #2185? Thanks.

Hi I'm working on analyzing the issue. Will let you know once I have an answer

stephenxs avatar Jun 13 '22 06:06 stephenxs