sonic-swss
sonic-swss copied to clipboard
sonic-net
Added support for front panel port prefix regex
What I did Removed the dependency on the "Ethernet" string in the SONiC code base and added support for extending the front panel port name pattern.
How I did it
Introduced FRONT_PANEL_PORT_PREFIX_REGEX that extends the old FRONT_PANEL_PORT_PREFIX ("Ethernet") Updated all the relevant usage of the "Ethernet" throughout the code base to use the new regex pattern How to verify it Pass all UT and CI testing.
Why I did it In order to support distinguishing between different types of front panel ports in a maintainable fashion. Specifically, we are planning to bring up a system with 'service' ports (in addition to the regular ethernet data ports) - these are lower speed ports that used for connection to accelerators, internal loopbacks and more.
- Related Commits and Merge Strategy This is part of a group of related commits and should be merged after https://github.com/Azure/sonic-swss-common/pull/598 and https://github.com/Azure/sonic-buildimage/pull/10471 and https://github.com/Azure/sonic-py-swsssdk/pull/121.
The full merge order is:
- swss-common - https://github.com/Azure/sonic-swss-common/pull/598
- sonic-buildimage - https://github.com/Azure/sonic-buildimage/pull/10471
- swsssdk - https://github.com/Azure/sonic-py-swsssdk/pull/121
- all the rest https://github.com/Azure/sonic-utilities/pull/2127 https://github.com/Azure/sonic-snmpagent/pull/251 https://github.com/Azure/sonic-swss/pull/2223 https://github.com/Azure/sonic-platform-daemons/pull/252 https://github.com/Azure/sonic-platform-common/pull/274
Depends on https://github.com/Azure/sonic-swss-common/pull/598.
May I know the motivation for the change? Was there any discussions or notes that I can refer?
This PR depends on https://github.com/Azure/sonic-swss-common/pull/598 so it will not pass until it merged
Sure - I have updated the description with a 'why I did it' section. @prsunny, please check it out, thanks.
@kcudnik @qiluo-msft - could you please check it out after my update? Checks will fail until related commits will be merged (in the description). Thank you!