sonic-swss
sonic-swss copied to clipboard
sonic-net
[gearbox] Support setting tx taps on gearbox ports
What I did This change adds support for setting tx tap or tuning values on gearbox ports. It uses the SAI attributes such as SAI_PORT_SERDES_ATTR_TX_FIR_PRE1 to communicate with SAI-based gearbox drivers. For the values, they are provided in the format like "system_tx_fir_pre2": [1,1] for an interface from gearbox_config.json.
Why I did it
How I verified it We verified that values provided in https://github.com/Azure/sonic-buildimage/pull/10084 are set to the chip with this change.
Added test to tests/test_gearbox.py. The added test will not pass until the following two changes (which should be merged first) are merged: Support SAI_PORT_ATTR_PORT_SERDES_ID on vs gearbox: https://github.com/Azure/sonic-sairedis/pull/1082 Add gearbox taps to vs gearbox_config.json: https://github.com/Azure/sonic-buildimage/pull/11480
Details if related
@byu343 do ensure that during warm-reboot we are not setting these taps because it can cause the port to flap?
What I did This change adds support for setting tx tap or tuning values on gearbox ports. It uses the SAI attributes such as SAI_PORT_SERDES_ATTR_TX_FIR_PRE1 to communicate with SAI-based gearbox drivers. For the values, they are provided in the format like "system_tx_fir_pre2": [1,1] for an interface from gearbox_config.json.
Why I did it
How I verified it We verified that values provided in Azure/sonic-buildimage#10084 are set to the chip with this change.
Details if related
@byu343 is this "system_tx_fir_pre2": [1,1]" format captured in HLD? can you point me the HLD?
@byu343 is this "system_tx_fir_pre2": [1,1]" format captured in HLD? can you point me the HLD?
No, this is no captured by HLD. I followed the existing format for system_lanes, such as: "system_lanes": [6,7]. And each value in system_tx_fir_pre2 matches the corresponding lane.
@byu343 do ensure that during warm-reboot we are not setting these taps because it can cause the port to flap?
For the credo gearbox phys, I think warm-reboot support is not considered for now.
![azure-pipelines[bot] avatar](https://avatars.githubusercontent.com/in/9426?v=4 "Published by a pub.dev verified publisher"){kind=small}
Couple of questions on this:
- Is adding the taps to the gearbox_config files mandatory or optional?
- Do you expect the SAI calls to be implemented in the platform mandatorily for these or are they optional?
Regards, Arpit
Couple of questions on this:
- Is adding the taps to the gearbox_config files mandatory or optional?
- Do you expect the SAI calls to be implemented in the platform mandatorily for these or are they optional?
Regards, Arpit
Hi Arpit, whether to provide those values in gearbox_config.json for any platform is optional. If orchagent finds the values from the gearbox_config.json, it will calls SAI implementation with the values; if it cannot, there is no calls to SAI for setting the tuning/tap values, so the tuning/tap support is not mandatory for the phy driver.
Commenter does not have sufficient privileges for PR 2158 in repo sonic-net/sonic-swss
