Handle dual ToR neighbor miss scenario

[theasianpianist]

This is the master branch duplicate of PR #2137

• When orchagent receives a neighbor update with a zero MAC:

  • If the neighbor IP is configured for a specific mux cable port in the MUX_CABLE table in CONFIG_DB, handle the neighbor normally (if active for the port, no action is needed. if standby, a tunnel route is created for the neighbor IP)
  • If the neighbor IP is not configured for a specific port, create a tunnel route for the IP to the peer switch.
    • When these neighbor IPs are eventually resolved, remove the tunnel route and handle the neighbor normally.

• When creating/initializing a mux cable object, set the internal state to standby to match the constructor behavior.

• Various formatting fixes inside test_mux.py

• Remove references to deprecated @pytest.yield_fixture

• Add dual ToR neighbor miss test cases:

  • Test cases and expected results are described in mux_neigh_miss_tests.py. These descriptions are used by the generic test runner test_neighbor_miss function to execute the test actions and verify expected results
  • Various setup fixtures and test info fixtures were added
  • Existing test cases were changed to use these setup fixtures for consistency

Signed-off-by: Lawrence Lee [email protected] Co-authored-by: Sumukha Tumkur Vani [email protected]

What I did

Why I did it

How I verified it

Details if related

[lgtm-com[bot]]

This pull request fixes 1 alert when merging 17ae9517f618fdc835a2a86783dfd7e5676673bf into 5a651d0aa6288e1c221f8a48e07020267b7fc3ab - view on LGTM.com

fixed alerts:

• 1 for Unused import

[lgtm-com[bot]]

This pull request fixes 1 alert when merging 17ae9517f618fdc835a2a86783dfd7e5676673bf into 5a651d0aa6288e1c221f8a48e07020267b7fc3ab - view on LGTM.com

fixed alerts:

• 1 for Unused import

[theasianpianist]

/Azp run

[azure-pipelines[bot]]

Azure Pipelines successfully started running 1 pipeline(s).

[theasianpianist]

/Azp run

[azure-pipelines[bot]]

Azure Pipelines successfully started running 1 pipeline(s).

[lgtm-com[bot]]

This pull request introduces 4 alerts when merging 66b505506c0e72a33981b4d02726148e5d3d3f3b into 0e5e7ba5cb5581c1ea4d470216cf3aadcd19fb94 - view on LGTM.com

new alerts:

• 2 for Wrong number of arguments in a call
• 1 for Unused local variable
• 1 for Variable defined multiple times

[lgtm-com[bot]]

This pull request introduces 4 alerts when merging 470835717fbac205b878e199a4f2a3d989645f35 into d7b5ff79907b22ed13a120d599eaf7c1ad8b6837 - view on LGTM.com

new alerts:

• 2 for Wrong number of arguments in a call
• 1 for Unused local variable
• 1 for Variable defined multiple times

[lgtm-com[bot]]

This pull request introduces 4 alerts when merging a72d155b0a29c838ea6bf5848c65b9262b9bb2a5 into 3161eaae6bd589bf8c9819aefb9d738047e0c9f8 - view on LGTM.com

new alerts:

• 2 for Wrong number of arguments in a call
• 1 for Unused local variable
• 1 for Variable defined multiple times

[prsunny]

/azp run

[azure-pipelines[bot]]

Azure Pipelines successfully started running 1 pipeline(s).

[prsunny]

/azp run

[azure-pipelines[bot]]

Azure Pipelines successfully started running 1 pipeline(s).