sonic-swss icon indicating copy to clipboard operation
sonic-swss copied to clipboard

[Buffer] Fix the bug that buffer configuration will cause failed logs during warm restart.

Open steven-guo-ec opened this issue 3 years ago • 4 comments
trafficstars

  • What I do: Let BufferMgr not execute the entries which are already in APPL_DB after a warm restart.

  • Why I did it: After warm start, the BufferMgr will set entries into APPL_DB which already exist. It will cause bufferorch to do a modification event. But, currently, modifying the buffer configuration is not supported in SAI, and it will print error messages. The error messages will cause test cases to fail.

  • How I verify it: With this enhancement, the syslog will not appear the error messages about Buffer during a warm restart.

steven-guo-ec avatar Dec 20 '21 01:12 steven-guo-ec

@steven-guo-ec can you please elaborate on which buffer attributes are not supported in SAI? IMO buffer orch will not set create-only attributes

stephenxs avatar Dec 20 '21 12:12 stephenxs

Please add VS tests

prsunny avatar Jan 26 '22 03:01 prsunny

SAI_BUFFER_POOL_ATTR_SIZE and SAI_BUFFER_PROFILE_ATTR_BUFFER_SIZE is not supported to set after they were created, they can be configured only when creating them.

steven-guo-ec avatar Jan 26 '22 03:01 steven-guo-ec

SAI_BUFFER_POOL_ATTR_SIZE and SAI_BUFFER_PROFILE_ATTR_BUFFER_SIZE is not supported to set after they were created, they can be configured only when creating them.

Thanks. But this does not comply with SAI definition. Check SAI_BUFFER_POOL_ATTR_SIZE and SAI_BUFFER_PROFILE_ATTR_RESERVED_BUFFER_SIZE for details. So IMO this should be fixed by vendor SAI.

stephenxs avatar Jan 26 '22 04:01 stephenxs