sonic-swss icon indicating copy to clipboard operation
sonic-swss copied to clipboard

Published 20 hours ago • verified publisher icon sonic-net

[SAG]: Add SAG implementation

Open superchild opened this issue 3 years ago • 24 comments

What I did

  • Add static anycast gateway implementation in intfmgr/intforch
  • Revise routeroch's API to handle add/delete IPv6 link-local route
  • Add related testcases

Why I did it

  • To support static anycast gateway feature

How I verified it

  • Using vs environment to execute the test cases, all test cases passed

Details if related

Signed-off-by: Jimi Chen [email protected]

superchild avatar Oct 20 '21 07:10 superchild

@prsunny could you please help to review the code? The related schema changed PR is sonic-swss-common#540, but it doesn't have reviewer yet. Could you please help to assign someone to review? Thanks.

superchild avatar Oct 28 '21 01:10 superchild

@kperumalbfn The new SAG_TABLE added in APPL_DB is updated in the HLD PR, please help to check.

superchild avatar Nov 16 '21 02:11 superchild

all the comments are addressed, @prsunny please help to review to see if you are ok to approve. Branch conflicts and build failure need be addressed by @superchild

zhangyanzhao avatar Dec 02 '21 16:12 zhangyanzhao

@zhangyanzhao , the code conflict has been resolved. For the build failure, it's due to sonic-swss-common#540 not merged yet. For that schema PR, the build failure seems timeout for the build task. I don't have the permission to trigger the CI build again, could you help to trigger the build again?

superchild avatar Dec 03 '21 07:12 superchild

@prsunny could you please help to view? @zhangyanzhao the CI build needs sonic-swss-common#540 to be merged first, and then I'll trigger another build to test

superchild avatar Dec 10 '21 06:12 superchild

@prsunny @kperumalbfn Could you help to review? Thanks.

superchild avatar May 06 '22 13:05 superchild

@venkatmahalingam , please review

prsunny avatar May 07 '22 00:05 prsunny