sonic-swss
sonic-swss copied to clipboard
[fabricportsorch] Collect counters for fabric links
This change is enabling collections of fabric link counters as port and queue stats.
Currently only fabric asics can be collected, so collection is disabled for switch asics. The reasons are that BCM SAI supports up to 256 logical ports, which is not enough for ports + fabric lanes, and fabric queue counters are not supported by SAI at this moment.
The following sonic-swss-common PR is required: PR #551
sonic-utilities PR #1860 adds the
corresponding show fabric counters
CLI command.
@skeesara-nokia , @vganesan-nokia - please help review, thanks.
Can you check the build failure?
/Azp run
Azure Pipelines successfully started running 1 pipeline(s).
Can you check the build failure?
We will need https://github.com/Azure/sonic-swss-common/pull/551 to merge to get a passing build.
Please add VS tests
The committers listed above are authorized under a signed CLA.
- :white_check_mark: login: mlorrillere / name: Maxime Lorrillere (dde035b23401c42080d14b84e9e9a824393481a8)
/easycla
@mlorrillere please check on code coverage failures.
@mlorrillere - any update?
@mlorrillere - any update?
Hi @rlhui I was waiting for sonic-buildimage PR #11997 to merge before updating this review.
It looks like there was a duplicate sonic-buildimage PR #12098 merged a few days ago. I'll update this PR shortly with test coverage.
Tagging @jfeng-arista
@rlhui - all checks have passed.
@arlakshm @rlhui Can we merge this?