sonic-swss icon indicating copy to clipboard operation
sonic-swss copied to clipboard

[fabricportsorch] Collect counters for fabric links

Open mlorrillere opened this issue 3 years ago • 9 comments

This change is enabling collections of fabric link counters as port and queue stats.

Currently only fabric asics can be collected, so collection is disabled for switch asics. The reasons are that BCM SAI supports up to 256 logical ports, which is not enough for ports + fabric lanes, and fabric queue counters are not supported by SAI at this moment.

The following sonic-swss-common PR is required: PR #551 sonic-utilities PR #1860 adds the corresponding show fabric counters CLI command.

mlorrillere avatar Oct 06 '21 16:10 mlorrillere

@skeesara-nokia , @vganesan-nokia - please help review, thanks.

rlhui avatar Oct 20 '21 17:10 rlhui

Can you check the build failure?

arlakshm avatar Nov 11 '21 15:11 arlakshm

/Azp run

arlakshm avatar Nov 16 '21 20:11 arlakshm

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Nov 16 '21 20:11 azure-pipelines[bot]

Can you check the build failure?

We will need https://github.com/Azure/sonic-swss-common/pull/551 to merge to get a passing build.

mlorrillere avatar Nov 16 '21 21:11 mlorrillere

Please add VS tests

prsunny avatar May 04 '22 22:05 prsunny

CLA Signed

The committers listed above are authorized under a signed CLA.

  • :white_check_mark: login: mlorrillere / name: Maxime Lorrillere (dde035b23401c42080d14b84e9e9a824393481a8)

/easycla

mlorrillere avatar Aug 02 '22 21:08 mlorrillere

@mlorrillere please check on code coverage failures.

abdosi avatar Aug 17 '22 17:08 abdosi

@mlorrillere - any update?

rlhui avatar Sep 20 '22 06:09 rlhui

@mlorrillere - any update?

Hi @rlhui I was waiting for sonic-buildimage PR #11997 to merge before updating this review.

It looks like there was a duplicate sonic-buildimage PR #12098 merged a few days ago. I'll update this PR shortly with test coverage.

mlorrillere avatar Sep 20 '22 16:09 mlorrillere

Tagging @jfeng-arista

mlorrillere avatar Sep 20 '22 17:09 mlorrillere

@rlhui - all checks have passed.

mlorrillere avatar Sep 22 '22 16:09 mlorrillere

@arlakshm @rlhui Can we merge this?

kenneth-arista avatar Oct 05 '22 21:10 kenneth-arista