sonic-swss icon indicating copy to clipboard operation
sonic-swss copied to clipboard

Published 20 hours ago • verified publisher icon sonic-net

Add support for voq counters in portsorch.

Open skbarista opened this issue 4 years ago • 9 comments

What I did

  1. Add m_voq_ids to SystemPortInfo to maintain the list of queue ids.
  2. Add two new tables COUNTERS_SYSTEM_PORT_NAME_MAP and COUNTERS_VOQ_NAME_MAP to enable queuestat to differentiate between Port Tx queues and Voqs.
  3. Add a new function initializeVoqs that retrieves the number of voqs for a system port and stores the voq object ids in m_voq_ids
  4. Add code to handle queue type SAI_QUEUE_TYPE_UNICAST_VOQ.
  5. Initialize voqs and populate COUNTERS_SYSTEM_PORT_NAME_MAP in addSystemPorts function.
  6. Update generateQueueMap to generate queue maps for both Txqs and Voq. For PHY ports in a voq system both Txqs and Voqs are instantiated. For Voqs of remote system port, only Voq counters are initialized.

Why I did it

Add support for voq counters.

How I verified it

Modified queuestat locally and confirming the counters are populated for Voqs.

Details if related

skbarista avatar Sep 17 '21 00:09 skbarista

CLA assistant check
All CLA requirements met.

microsoft-cla-retired[bot] avatar Sep 17 '21 00:09 microsoft-cla-retired[bot]

Build dependency on sonic-swss-common/pull/530

skbarista avatar Sep 17 '21 00:09 skbarista

@skbarista, can you fix the conflicts ?

arlakshm avatar May 04 '22 20:05 arlakshm

@skbarista, can you fix the conflicts ?

arlakshm avatar May 13 '22 01:05 arlakshm

@arlakshm sorry missed this message. Will do it next week and refresh the pr. Thanks, Sambath

skbarista avatar May 13 '22 17:05 skbarista

@rlhui @abdosi sorry was not able to get to resolve the conflict. Let me do this tomorrow.

skbarista avatar May 24 '22 05:05 skbarista

Hi @skbarista, are conflicts resolved

arlakshm avatar May 31 '22 19:05 arlakshm

@arlakshm I resolved the conflict and I am looking at some test failures from the build. I see there are some new conflicts. Will resolve them once I fix the test failures.

skbarista avatar Jun 06 '22 17:06 skbarista

@arlakshm I resolved the conflict and I am looking at some test failures from the build. I see there are some new conflicts. Will resolve them once I fix the test failures.

@arlakshm https://github.com/Azure/sonic-sairedis/pull/1061 fixes the build failure for this pull request.

skbarista avatar Jun 10 '22 14:06 skbarista

@skbarista Can you please resolve conflicts and take care of build errors ?

vmittal-msft avatar Sep 19 '22 04:09 vmittal-msft

/azp run

vmittal-msft avatar Sep 22 '22 23:09 vmittal-msft

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Sep 22 '22 23:09 azure-pipelines[bot]

/azp run

skbarista avatar Sep 23 '22 15:09 skbarista

Commenter does not have sufficient privileges for PR 1913 in repo sonic-net/sonic-swss

azure-pipelines[bot] avatar Sep 23 '22 15:09 azure-pipelines[bot]

/azpw run sonic-buildimage

skbarista avatar Sep 23 '22 15:09 skbarista

/AzurePipelines run sonic-buildimage

mssonicbld avatar Sep 23 '22 15:09 mssonicbld

No pipelines are associated with this pull request.

azure-pipelines[bot] avatar Sep 23 '22 15:09 azure-pipelines[bot]

/azp run sonic-net/sonic-swss

vmittal-msft avatar Sep 23 '22 17:09 vmittal-msft

No pipelines are associated with this pull request.

azure-pipelines[bot] avatar Sep 23 '22 17:09 azure-pipelines[bot]

/azp run

vmittal-msft avatar Sep 23 '22 22:09 vmittal-msft

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Sep 23 '22 22:09 azure-pipelines[bot]

/azp run

vmittal-msft avatar Sep 27 '22 23:09 vmittal-msft

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Sep 27 '22 23:09 azure-pipelines[bot]

/azp run

vmittal-msft avatar Sep 30 '22 04:09 vmittal-msft

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Sep 30 '22 04:09 azure-pipelines[bot]

@skbarista Can you please update your branch to latest and retry ?

vmittal-msft avatar Oct 01 '22 22:10 vmittal-msft

/azp run

vmittal-msft avatar Oct 05 '22 16:10 vmittal-msft

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Oct 05 '22 16:10 azure-pipelines[bot]