sonic-swss
sonic-swss copied to clipboard
sonic-net
[mirror] erspan ipv6 underlay
Why I did it Unlock erspan capability on td3 and beyond that supports erspan ipv6 encap.
What I did
How I verified it
-
Extend
test_MirrorAddSetRemove,test_MirrorToVlanAddRemove,test_MirrorToLagAddRemove,test_MirrorDestMoveVlan,test_MirrorDestMoveLagto vs test erspan ipv6 encap -
On td3
Details if related
Used brcm sai 4.3.3 that interacts with sdk 6.5.21
This pull request fixes 1 alert when merging b2f84750221f44096ca703f0be47b7dd40e67b11 into 64e33b38c8c3f242745f5541c4f74bf2260c7d56 - view on LGTM.com
fixed alerts:
- 1 for Unused local variable
![lgtm-com[bot] avatar](https://avatars.githubusercontent.com/in/17324?v=4 "Published by a pub.dev verified publisher"){kind=small}
This pull request fixes 1 alert when merging f25b22fb3134bd0f00d9c17700d3037c18f50843 into 64e33b38c8c3f242745f5541c4f74bf2260c7d56 - view on LGTM.com
fixed alerts:
- 1 for Unused local variable
![azure-pipelines[bot] avatar](https://avatars.githubusercontent.com/in/9426?v=4 "Published by a pub.dev verified publisher"){kind=small}
This pull request fixes 1 alert when merging e47d8ab5f99963256a60c33d2141155cb8d9f0b8 into 5d97b0571eaf3157cbf9fd74748ab7b51c18706d - view on LGTM.com
fixed alerts:
- 1 for Unused local variable
This pull request fixes 1 alert when merging 7c9dff248bb5c566adc7c87732478012116e5455 into 7aca82df3b56276625ce3d70ffb45b849003b0d8 - view on LGTM.com
fixed alerts:
- 1 for Unused local variable
Sorry for missing review. A quick question, are src IP and dst IP required to be the same version? If so, I suggest adding some check to avoid some negative scenarios, such as src ip is IPv4 while dst ip is IPv6. And the cli in sonic-utility and Yang model are also needed to be updated to support IPv6 erspan.
This pull request fixes 1 alert when merging ba31e8eafdad9928dff3b2a5c78f12ce26b4f1a0 into 5d5c1692198c5c9c3b43f79406f074d2831c0884 - view on LGTM.com
fixed alerts:
- 1 for Unused local variable