sonic-swss
sonic-swss copied to clipboard
[pfcwd] Observe pfc enable bits change
What I did Implement 2.6.3 Queue Reconfiguration or Removal in PFC watchdog HLD
Why I did it Fix issue 2 stated in https://github.com/Azure/sonic-swss/issues/842: "A mechanism should be introduced to let PFCWD respond to this event"
How I verified it vs test and on brcm
vs test the following scenarios:
- Set PFC WD config on port before set any PFC enable bit
- Set PFC enable on {port, TC 3}
- Clear PFC enable on {port, TC 3}, and set PFC enable on {port, TC 4}
- Set big red switch mode on top of PFC WD config on port
- Clear PFC enable on {port, TC 4}, and set PFC enable on {port, TC 3}
- Clear all PFC enable bits (i.e., Clear PFC enable on {port, TC 3})
At each PFC enable bit change step, check
- port and queue level entry in FLEX_COUNTER_DB
- COUNTERS_DB
PFC_WD_STATUS,PFC_WD_QUEUE_STATS_DEADLOCK_DETECTED,PFC_WD_QUEUE_STATS_DEADLOCK_RESTOREDvalue - APPL_DB queue in-storm status
Details if related Let pfcwd orch be an observer of qos orch PFC enable bits change, and update db registration accordingly.
Fix https://github.com/Azure/sonic-swss/issues/842
Peel off current code refactoring part in PR https://github.com/Azure/sonic-swss/pull/1696
- [ ] https://github.com/Azure/sonic-swss/pull/1696
This pull request fixes 2 alerts when merging 4ce1bcebe1e62d30e603a4bab6873362780a7c6c into 66e1aab8689de4ee532a8301b8bb8414519fdf24 - view on LGTM.com
fixed alerts:
- 2 for Unused import
@wendani , can you do a proper pr, too many commits in your pr. https://www.thinkful.com/learn/github-pull-request-tutorial/#:~:text=Time%20to%20Submit%20Your%20First%20PR%201%20Go,github%20username%3E%2Fguides-github-pull-request.git%20in%20your%20terminal%20More%20items...%20