sonic-swss-common icon indicating copy to clipboard operation
sonic-swss-common copied to clipboard

Event and alarm management: Add tables for event and alarms.

Open bhaveshdell opened this issue 1 year ago • 21 comments

Why I did it This PR contains code changes for providing extension to the Event Framework as specified in the https://github.com/sonic-net/SONiC/pull/1409

How I did it Followed design specified in https://github.com/sonic-net/SONiC/pull/1409. Add new tables for events and alarms.

bhaveshdell avatar Jan 30 '24 22:01 bhaveshdell

@bhaveshdell This seems to be only 1 file change I see in this code PR. Where are all other changes? PRs? could you please list them in HLD PR: sonic-net/SONiC#1409.

shyam77git avatar Jan 31 '24 20:01 shyam77git

@bhaveshdell This seems to be only 1 file change I see in this code PR. Where are all other changes? PRs? could you please list them in HLD PR: sonic-net/SONiC#1409.

The PRs are listed in sonic-net/SONiC#1409

https://github.com/sonic-net/sonic-swss-common/pull/852 https://github.com/sonic-net/sonic-buildimage/pull/17949

bhaveshdell avatar Jan 31 '24 20:01 bhaveshdell

@bhaveshdell This seems to be only 1 file change I see in this code PR. Where are all other changes? PRs? could you please list them in HLD PR: sonic-net/SONiC#1409.

The PRs are listed in sonic-net/SONiC#1409

#852 sonic-net/sonic-buildimage#17949

OK, so in all these two PRs to be reviewed? any more upcoming PR? could you add me as reviewer to them both? Add others too so that review can be expedited

shyam77git avatar Jan 31 '24 21:01 shyam77git

@bhaveshdell This seems to be only 1 file change I see in this code PR. Where are all other changes? PRs? could you please list them in HLD PR: sonic-net/SONiC#1409.

The PRs are listed in sonic-net/SONiC#1409 #852 sonic-net/sonic-buildimage#17949

OK, so in all these two PRs to be reviewed? any more upcoming PR? could you add me as reviewer to them both? Add others too so that review can be expedited

@shyam77git Only these 2 PRs. Repo owner can add reviewer.

bhaveshdell avatar Feb 02 '24 00:02 bhaveshdell

/azpw run Azure.sonic-swss-common

bhaveshdell avatar Feb 02 '24 05:02 bhaveshdell

/AzurePipelines run Azure.sonic-swss-common

mssonicbld avatar Feb 02 '24 05:02 mssonicbld

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Feb 02 '24 05:02 azure-pipelines[bot]

@bhaveshdell This seems to be only 1 file change I see in this code PR. Where are all other changes? PRs? could you please list them in HLD PR: sonic-net/SONiC#1409.

The PRs are listed in sonic-net/SONiC#1409 #852 sonic-net/sonic-buildimage#17949

OK, so in all these two PRs to be reviewed? any more upcoming PR? could you add me as reviewer to them both? Add others too so that review can be expedited

@shyam77git Only these 2 PRs. Repo owner can add reviewer.

@prgeor / @zhangyanzhao - please add reviewers to this HLD. This is a per-requisite for FM infra HLD: https://github.com/sonic-net/SONiC/pull/1527

shyam77git avatar Feb 04 '24 01:02 shyam77git

/azpw run Azure.sonic-swss-common

bhaveshdell avatar Feb 20 '24 20:02 bhaveshdell

/AzurePipelines run Azure.sonic-swss-common

mssonicbld avatar Feb 20 '24 20:02 mssonicbld

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Feb 20 '24 20:02 azure-pipelines[bot]

@qiluo-msft @liuh-80 @shyam77git Please assign reviewers. Also, the build checks seem to be failing for reasons not related to the changes in this PR. Can you please check?

jeff-yin avatar Feb 28 '24 23:02 jeff-yin

/azpw run

bhaveshdell avatar Mar 14 '24 17:03 bhaveshdell

/AzurePipelines run

mssonicbld avatar Mar 14 '24 17:03 mssonicbld

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Mar 14 '24 17:03 azure-pipelines[bot]

/azpw run

bhaveshdell avatar Mar 16 '24 17:03 bhaveshdell

/AzurePipelines run

mssonicbld avatar Mar 16 '24 17:03 mssonicbld

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Mar 16 '24 17:03 azure-pipelines[bot]

/azpw run

bhaveshdell avatar Mar 16 '24 21:03 bhaveshdell

/AzurePipelines run

mssonicbld avatar Mar 16 '24 21:03 mssonicbld

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Mar 16 '24 21:03 azure-pipelines[bot]

@qiluo-msft @zbud-msft - Can we please get approval/merge on this PR?

bhavini-gada avatar May 07 '24 20:05 bhavini-gada