sonic-swss-common
sonic-swss-common copied to clipboard
Event and alarm management: Add tables for event and alarms.
Why I did it This PR contains code changes for providing extension to the Event Framework as specified in the https://github.com/sonic-net/SONiC/pull/1409
How I did it Followed design specified in https://github.com/sonic-net/SONiC/pull/1409. Add new tables for events and alarms.
@bhaveshdell This seems to be only 1 file change I see in this code PR. Where are all other changes? PRs? could you please list them in HLD PR: sonic-net/SONiC#1409.
@bhaveshdell This seems to be only 1 file change I see in this code PR. Where are all other changes? PRs? could you please list them in HLD PR: sonic-net/SONiC#1409.
The PRs are listed in sonic-net/SONiC#1409
https://github.com/sonic-net/sonic-swss-common/pull/852 https://github.com/sonic-net/sonic-buildimage/pull/17949
@bhaveshdell This seems to be only 1 file change I see in this code PR. Where are all other changes? PRs? could you please list them in HLD PR: sonic-net/SONiC#1409.
The PRs are listed in sonic-net/SONiC#1409
OK, so in all these two PRs to be reviewed? any more upcoming PR? could you add me as reviewer to them both? Add others too so that review can be expedited
@bhaveshdell This seems to be only 1 file change I see in this code PR. Where are all other changes? PRs? could you please list them in HLD PR: sonic-net/SONiC#1409.
The PRs are listed in sonic-net/SONiC#1409 #852 sonic-net/sonic-buildimage#17949
OK, so in all these two PRs to be reviewed? any more upcoming PR? could you add me as reviewer to them both? Add others too so that review can be expedited
@shyam77git Only these 2 PRs. Repo owner can add reviewer.
/azpw run Azure.sonic-swss-common
/AzurePipelines run Azure.sonic-swss-common
Azure Pipelines successfully started running 1 pipeline(s).
@bhaveshdell This seems to be only 1 file change I see in this code PR. Where are all other changes? PRs? could you please list them in HLD PR: sonic-net/SONiC#1409.
The PRs are listed in sonic-net/SONiC#1409 #852 sonic-net/sonic-buildimage#17949
OK, so in all these two PRs to be reviewed? any more upcoming PR? could you add me as reviewer to them both? Add others too so that review can be expedited
@shyam77git Only these 2 PRs. Repo owner can add reviewer.
@prgeor / @zhangyanzhao - please add reviewers to this HLD. This is a per-requisite for FM infra HLD: https://github.com/sonic-net/SONiC/pull/1527
/azpw run Azure.sonic-swss-common
/AzurePipelines run Azure.sonic-swss-common
Azure Pipelines successfully started running 1 pipeline(s).
@qiluo-msft @liuh-80 @shyam77git Please assign reviewers. Also, the build checks seem to be failing for reasons not related to the changes in this PR. Can you please check?
/azpw run
/AzurePipelines run
Azure Pipelines successfully started running 1 pipeline(s).
/azpw run
/AzurePipelines run
Azure Pipelines successfully started running 1 pipeline(s).
/azpw run
/AzurePipelines run
Azure Pipelines successfully started running 1 pipeline(s).
@qiluo-msft @zbud-msft - Can we please get approval/merge on this PR?