sonic-swss-common icon indicating copy to clipboard operation
sonic-swss-common copied to clipboard

Add ProfileProvider class to support read profile config from PROFILE_DB.

Open liuh-80 opened this issue 2 years ago • 7 comments

Why I did it

Add default value and profile support to swss-swss-common.

How I did it

Add ProfileProvider class to support read profile config from PROFILE_DB.

How to verify it

Add new UT. Pass all existing UT and E2E test.

Which release branch to backport (provide reason below if selected)

  • [ ] 201811
  • [ ] 201911
  • [ ] 202006
  • [ ] 202012
  • [ ] 202106
  • [ ] 202111

Description for the changelog

Add ProfileProvider class to support read profile config from PROFILE_DB.

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

liuh-80 avatar Sep 09 '22 04:09 liuh-80

This PR depends on another PR to pass UT: https://github.com/sonic-net/sonic-swss-common/pull/681 The reason is UT need modify redis config to create a new UT, which is part of azure pipeline change.

liuh-80 avatar Sep 09 '22 06:09 liuh-80

    "LOGLEVEL_DB" : {

There is a ongoing PR to remove this DB. Possible to use it?


In reply to: 1260486336


In reply to: 1260486336


Refers to: tests/redis_multi_db_ut_config/database_config1.json:25 in 9b60524. [](commit_id = 9b60524cc312df68a6feed4fb3e0fec60d63d1fb, deletion_comment = False)

qiluo-msft avatar Sep 28 '22 07:09 qiluo-msft

    "LOGLEVEL_DB" : {

There is a ongoing PR to remove this DB. Possible to use it?

Refers to: tests/redis_multi_db_ut_config/database_config1.json:25 in 9b60524. [](commit_id = 9b60524, deletion_comment = False)

I check the loglevel PR, seems that PR only move logger table from LOGLEVEL_DB, seems still something left in that DB. So, before LOGLEVEL_DB been complete clean-up in database_config.json and schema.h and table.cpp, we can't use ID for that DB.

liuh-80 avatar Sep 28 '22 07:09 liuh-80

/azp run

liuh-80 avatar Sep 29 '22 00:09 liuh-80

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Sep 29 '22 01:09 azure-pipelines[bot]

Will merge after this validation pass: https://github.com/sonic-net/sonic-buildimage/pull/10575

liuh-80 avatar Oct 10 '22 07:10 liuh-80

Will merge this PR after the validation PR passed: https://github.com/sonic-net/sonic-buildimage/pull/10575

liuh-80 avatar Oct 11 '22 01:10 liuh-80

Could you check build failures?

qiluo-msft avatar Feb 18 '23 01:02 qiluo-msft

Could you check build failures? The build failure caused by code change in sairedis, following PR will fix it: https://github.com/sonic-net/sonic-swss-common/pull/747

liuh-80 avatar Feb 20 '23 01:02 liuh-80

/azp run

liuh-80 avatar Feb 20 '23 03:02 liuh-80

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Feb 20 '23 03:02 azure-pipelines[bot]