sonic-swss-common
sonic-swss-common copied to clipboard
sonic-net
Added front panel port prefix regex to schema.h
- What I did Removed the dependency on the "Ethernet" string in the SONiC code base and added support for extending the front panel port name pattern.
- How I did it 1. Introduced FRONT_PANEL_PORT_PREFIX_REGEX that extends the old FRONT_PANEL_PORT_PREFIX ("Ethernet") 2. Updated all the relevant usage of the "Ethernet" throughout the code base to use the new regex pattern
- How to verify it Pass all UT and CI testing.
- Why I did it In order to support distinguishing between different types of front panel ports in a maintainable fashion. Specifically, we are planning to bring up a system with 'service' ports (in addition to the regular ethernet data ports) - these are lower speed ports that used for connection to accelerators, internal loopbacks and more.
- Related Commits and Merge Strategy This is part of a group of related commits and should be merged first. The full merge order is:
- swss-common - https://github.com/Azure/sonic-swss-common/pull/598
- sonic-buildimage - https://github.com/Azure/sonic-buildimage/pull/10471
- swsssdk - https://github.com/Azure/sonic-py-swsssdk/pull/121
- all the rest https://github.com/Azure/sonic-utilities/pull/2127 https://github.com/Azure/sonic-snmpagent/pull/251 https://github.com/Azure/sonic-swss/pull/2223 https://github.com/Azure/sonic-platform-daemons/pull/252 https://github.com/Azure/sonic-platform-common/pull/274
- What I did Removed the dependancy on the "Ethernet" string in the SONiC code base and added support for extending the front panel port name pattern.
- How I did it 1. Introduced FRONT_PANEL_PORT_PREFIX_REGEX that extends the old FRONT_PANEL_PORT_PREFIX ("Ethernet") 2. Updated all the relevant usage of the "Ethernet" throughout the code base to use the new regex pattern
- How to verify it Pass all UT and CI testing.
Please also add a section "why you did this change"
- What I did Removed the dependancy on the "Ethernet" string in the SONiC code base and added support for extending the front panel port name pattern. - How I did it 1. Introduced FRONT_PANEL_PORT_PREFIX_REGEX that extends the old FRONT_PANEL_PORT_PREFIX ("Ethernet") 2. Updated all the relevant usage of the "Ethernet" throughout the code base to use the new regex pattern - How to verify it Pass all UT and CI testing.
Please also add a section "why you did this change"
@prgeor Added, please check it out
![azure-pipelines[bot] avatar](https://avatars.githubusercontent.com/in/9426?v=4 "Published by a pub.dev verified publisher"){kind=small}
@kcudnik @qiluo-msft - could you please check it out after my update (I have changed the definition in response to CR comments on related commits). Thanks! The checkers failure are not related to my change (happens on all PRs lately) - I reported the issue to the admins.
@qiluo-msft - hi, I rebased my branch and I see all checks are passing now.
the overall motivation is not quite clear. can you describe what are you trying to achieve here? here is the sonic port naming convention. for new port names convention to be introduced, we need to make a proposal first here. https://github.com/sonic-net/SONiC/blob/master/doc/sonic-port-name.md
@lguohan @prgeor - I have added a PR with the design doc - https://github.com/sonic-net/SONiC/pull/1092
we need a design doc to describe the overall efforts here.
@lguohan @prgeor Hi, please check my (approved) PR - https://github.com/sonic-net/SONiC/pull/1092
The committers listed above are authorized under a signed CLA.
- :white_check_mark: login: itamar-talmon (e1e7e60ae07131c592865aab58514115ff9a9289)
![linux-foundation-easycla[bot] avatar](https://avatars.githubusercontent.com/in/17893?v=4 "Published by a pub.dev verified publisher"){kind=small}