sonic-sairedis icon indicating copy to clipboard operation
sonic-sairedis copied to clipboard

Sonic sairedis changes for SAI SRV6

Open kperumalbfn opened this issue 3 years ago • 14 comments

sairedis changes to support SAI SRV6 changes - opencomputeproject/SAI@2e934ff

Update SAI SEGMENTROUTE object to SAI SRV6 object Serialize and deserialize APIs for SRV6 MY_SID_ENTRY object

These changes are needed to update Sonic SAI refpoint with SRV6 changes.

SAI refpoint with SRV6 update and this PR has to be merged together.

kperumalbfn avatar Aug 24 '21 21:08 kperumalbfn

@kcudnik latest sairedis changes on top of your recent commits.

kperumalbfn avatar Aug 24 '21 21:08 kperumalbfn

@kcudnik SAI tag with SRV6 changes is not yet created which is needed for Sonic 202111 release. This PR has to be merged along with that.

kperumalbfn avatar Aug 24 '21 21:08 kperumalbfn

can you also make unittsts in sairedis/unittest, you will find there directory structure and you can follow the format

kcudnik avatar Sep 01 '21 18:09 kcudnik

@kcudnik unittests are added for srv6

kperumalbfn avatar Sep 01 '21 19:09 kperumalbfn

great, now please make this compile right :)

kcudnik avatar Sep 01 '21 19:09 kcudnik

great, now please make this compile right :)

@kcudnik This PR has SAI dependencies. Compilation will be successful only when SAI refpoint is updated.

We need SAI tag with the below commit, may be SAI 1.9 for Sonic 202111 release.

https://github.com/opencomputeproject/SAI/commit/2e934ff

kperumalbfn avatar Sep 01 '21 20:09 kperumalbfn

you can update SAI pointer in the same pr

kcudnik avatar Sep 02 '21 03:09 kcudnik

@kcudnik @rlhui Can we update Sonic's SAI refpoint to the latest one in SAI(v1.9.0-rc1)?

kperumalbfn avatar Sep 02 '21 17:09 kperumalbfn

@lguohan can you response

Can we update Sonic's SAI refpoint to the latest one in SAI(v1.9.0-rc1)?

kcudnik avatar Sep 02 '21 17:09 kcudnik

please fix conflicts

kcudnik avatar Sep 21 '21 17:09 kcudnik

@kcudnik I have updated SAI version to 1.9.0 and added changes to new modules ipsec and my_mac.

kperumalbfn avatar Sep 21 '21 17:09 kperumalbfn

please fix conflicts

Reports conflict in SAI submodule file. How do we resolve this?

kperumalbfn avatar Sep 21 '21 18:09 kperumalbfn

@kcudnik Any steps before updating the SAI submodule? Please let me know if there are any steps to be followed.

kperumalbfn avatar Sep 21 '21 20:09 kperumalbfn

@kcudnik closing this PR and opening a new one https://github.com/Azure/sonic-sairedis/pull/937

kperumalbfn avatar Sep 21 '21 21:09 kperumalbfn