sonic-sairedis icon indicating copy to clipboard operation
sonic-sairedis copied to clipboard

Published 20 hours ago • verified publisher icon sonic-net

test bulk api for vs tests

Open lguohan opened this issue 4 years ago • 7 comments

this is to test vs tests for the bulk api implementation. DO NOT merge this pr.

Signed-off-by: Guohan Lu [email protected]

lguohan avatar Nov 03 '20 14:11 lguohan

@kcudnik, i think the build api for syncd has some issue to pass the vs tests. can someone take a look?

lguohan avatar Nov 04 '20 19:11 lguohan

We recently talked that there is and issue and we want to disable "-l" flag, so why enable it in this pr ? just to test it ?

kcudnik avatar Nov 04 '20 20:11 kcudnik

@dmytroxshevchuk you added bulk api support can you take a look why this is failing ?

kcudnik avatar Nov 04 '20 20:11 kcudnik

@lguohan @kcudnik I added bulk API in syncd. As for me my mistake was with log level in case when bulk api is not implemented(its cause of much logs from syncd), for now it is fixed in PR #687, thanks for this. Regarding vs tests it was passed in my PR #656, when bulk was implemented in syncd, so its interesting why tests failing now. I will check why the tests fall.

dmytroxshevchuk avatar Nov 05 '20 10:11 dmytroxshevchuk

i do not know if it makes difference, but sync mode is now enabled by default on swss

lguohan avatar Nov 05 '20 11:11 lguohan

WIP: #694

dmytroxshevchuk avatar Nov 05 '20 13:11 dmytroxshevchuk

this could be revisited, we already have fallback for bulk api in syncd even if vendors don't support that

kcudnik avatar Jul 06 '21 12:07 kcudnik