sonic-sairedis icon indicating copy to clipboard operation
sonic-sairedis copied to clipboard

Published 20 hours ago • verified publisher icon sonic-net

Use temp view also in fast-reboot

Open arfeigin opened this issue 1 year ago • 5 comments

syncd_init_common.sh is checking fast-reboot by reading /proc/cmdline. However, /proc/cmdline will not change after config reload. So, consider a case like fast-reboot -> config reload. In the config reload process, syncd_init_common.sh will also treat it as fast-reboot and probably enter wrong logic.

arfeigin avatar Jul 04 '24 12:07 arfeigin

@kcudnik Can you please help reviewing this PR?

arfeigin avatar Jul 04 '24 12:07 arfeigin

@vaibhavhd Can you please reviewing this PR?

arfeigin avatar Jul 08 '24 16:07 arfeigin

Hi @vaibhavhd , could you please help review this?

Junchao-Mellanox avatar Jul 22 '24 03:07 Junchao-Mellanox

@vaibhavhd The change is in our internal 202405 branch and running in regression for few month now with no issues related to fast-reboot

stepanblyschak avatar Oct 17 '24 10:10 stepanblyschak

@arfeigin Can you please sync with master branch? The PR can't be merged because it's out-of-date with master branch

bingwang-ms avatar Oct 21 '24 16:10 bingwang-ms

@bingwang-ms , Can you please merge and cherry pick to 202405 ?

dprital avatar Nov 26 '24 07:11 dprital

Cherry-pick PR to 202405: https://github.com/sonic-net/sonic-sairedis/pull/1476

mssonicbld avatar Nov 30 '24 18:11 mssonicbld