sonic-sairedis icon indicating copy to clipboard operation
sonic-sairedis copied to clipboard

Published 20 hours ago • verified publisher icon sonic-net

[fastboot] Notify SAI that fastboot is done

Open Junchao-Mellanox opened this issue 1 year ago • 28 comments
trafficstars

Why I did this

Notify SAI that fastboot is done

How I did this

Set SAI_SWITCH_ATTR_FAST_API_ENABLE to false when fastboot is done

How I verify this

Manual test

Junchao-Mellanox avatar Jun 17 '24 02:06 Junchao-Mellanox

Hi @yxieca , @vaibhavhd , could you please kindly review it?

Junchao-Mellanox avatar Jun 17 '24 02:06 Junchao-Mellanox

Please fix errors

kcudnik avatar Jun 17 '24 05:06 kcudnik

/azpw run Azure.sonic-sairedis

Junchao-Mellanox avatar Jun 17 '24 07:06 Junchao-Mellanox

/AzurePipelines run Azure.sonic-sairedis

mssonicbld avatar Jun 17 '24 07:06 mssonicbld

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Jun 17 '24 07:06 azure-pipelines[bot]

@adyeung can you get someone from Broadcom to assess this change?

yxieca avatar Jun 20 '24 22:06 yxieca

@tushar-ty @vishnushetty please help review

adyeung avatar Jun 26 '24 20:06 adyeung

Hi, please hod on the review for a moment. I will need to update this PR.

Junchao-Mellanox avatar Jun 27 '24 01:06 Junchao-Mellanox

Hi @tushar-ty @vishnushetty , could you please kindly provide comment?

Junchao-Mellanox avatar Jul 04 '24 07:07 Junchao-Mellanox

Hi @adyeung, @tushar-ty, @vishnushetty, kindly reminder.

Junchao-Mellanox avatar Jul 09 '24 01:07 Junchao-Mellanox

Adding @Prasanth-KV to help review

adyeung avatar Jul 17 '24 21:07 adyeung

@Junchao-Mellanox can you check please the PR checker coverage issue?

liat-grozovik avatar Jul 24 '24 07:07 liat-grozovik

@Junchao-Mellanox can you check please the PR checker coverage issue?

Sure, working on it

Junchao-Mellanox avatar Jul 24 '24 07:07 Junchao-Mellanox

The new test case passed locally, but failed in github checker, I will investigate.

Junchao-Mellanox avatar Jul 24 '24 10:07 Junchao-Mellanox

/azpw run Azure.sonic-sairedis

Junchao-Mellanox avatar Jul 25 '24 01:07 Junchao-Mellanox

/AzurePipelines run Azure.sonic-sairedis

mssonicbld avatar Jul 25 '24 01:07 mssonicbld

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Jul 25 '24 01:07 azure-pipelines[bot]

/azpw run Azure.sonic-sairedis

Junchao-Mellanox avatar Jul 25 '24 06:07 Junchao-Mellanox

/AzurePipelines run Azure.sonic-sairedis

mssonicbld avatar Jul 25 '24 06:07 mssonicbld

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Jul 25 '24 06:07 azure-pipelines[bot]

Hi @kcudnik , could you please review and merge?

Junchao-Mellanox avatar Jul 26 '24 08:07 Junchao-Mellanox

@saiarcot895 could you please help to merge?

liat-grozovik avatar Jul 28 '24 10:07 liat-grozovik

Should be merged only after upstream of SAI version 2405.29.0.0. @Junchao-Mellanox , please mention it on PR description

dprital avatar Jul 30 '24 09:07 dprital

/azpw run Azure.sonic-sairedis

Junchao-Mellanox avatar Aug 05 '24 01:08 Junchao-Mellanox

/AzurePipelines run Azure.sonic-sairedis

mssonicbld avatar Aug 05 '24 01:08 mssonicbld

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Aug 05 '24 01:08 azure-pipelines[bot]

@kcudnik can you please help to merge?

liat-grozovik avatar Sep 03 '24 08:09 liat-grozovik

@saiarcot895 @kcudnik kindly reminder to merge this one

liat-grozovik avatar Sep 09 '24 14:09 liat-grozovik

Hi @kcudnik , could you please help merge this one?

Junchao-Mellanox avatar Oct 23 '24 08:10 Junchao-Mellanox

@Junchao-Mellanox Auto-cherry-pick seems not working on this PR. Can you please raise a PR to 202405 branch?

bingwang-ms avatar Nov 20 '24 21:11 bingwang-ms