sonic-sairedis icon indicating copy to clipboard operation
sonic-sairedis copied to clipboard

Support ASIC/SDK health event

Open stephenxs opened this issue 1 year ago • 8 comments

Support ASIC/SDK health event

  1. Handle vendor SAI ASIC/SDK health event and encode it
  2. Pass it to swss through the communication channel.

stephenxs avatar Jan 23 '24 02:01 stephenxs

a first glance this looks good, i will do a full review after you will move that out of draft

kcudnik avatar Jan 23 '24 09:01 kcudnik

/azpw run

stephenxs avatar Mar 27 '24 23:03 stephenxs

/AzurePipelines run

mssonicbld avatar Mar 27 '24 23:03 mssonicbld

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Mar 27 '24 23:03 azure-pipelines[bot]

Failure is not relevant to the PR. Retried.

test_sub_port_intf_nhg_accel failed (1 runs remaining out of 2).
	<class 'AssertionError'>
	Unexpected number of keys: expected=6, received=4 (('oid:0x2d00000000084a', 'oid:0x2d00000000084d', 'oid:0x2d00000000084c', 'oid:0x2d00000000084b')), table="ASIC_STATE:SAI_OBJECT_TYPE_NEXT_HOP_GROUP_MEMBER"
	[<TracebackEntry /agent/_work/1/s/sonic-swss/tests/test_sub_port_intf.py:1474>, <TracebackEntry /agent/_work/1/s/sonic-swss/tests/test_sub_port_intf.py:1410>, <TracebackEntry /agent/_work/1/s/sonic-swss/tests/dvslib/dvs_database.py:402>]
test_sub_port_intf_nhg_accel failed; it passed 0 out of the required 1 times.
	<class 'AssertionError'>
	Wrong # of default vrfs: 2, expected #: 1.
assert 2 == 1
  -2
  +1
	[<TracebackEntry /agent/_work/1/s/sonic-swss/tests/test_sub_port_intf.py:1463>, <TracebackEntry /agent/_work/1/s/sonic-swss/tests/test_sub_port_intf.py:86>, <TracebackEntry /agent/_work/1/s/sonic-swss/tests/test_sub_port_intf.py:393>]
test_sub_port_intf_oper_down_with_pending_neigh_route_tasks failed (1 runs remaining out of 2).
	<class 'AssertionError'>
	Wrong # of default vrfs: 2, expected #: 1.
assert 2 == 1
  -2
  +1
	[<TracebackEntry /agent/_work/1/s/sonic-swss/tests/test_sub_port_intf.py:1603>, <TracebackEntry /agent/_work/1/s/sonic-swss/tests/test_sub_port_intf.py:86>, <TracebackEntry /agent/_work/1/s/sonic-swss/tests/test_sub_port_intf.py:393>]
test_sub_port_intf_oper_down_with_pending_neigh_route_tasks failed; it passed 0 out of the required 1 times.
	<class 'AssertionError'>
	Wrong # of default vrfs: 2, expected #: 1.
assert 2 == 1
  -2
  +1
	[<TracebackEntry /agent/_work/1/s/sonic-swss/tests/test_sub_port_intf.py:1603>, <TracebackEntry /agent/_work/1/s/sonic-swss/tests/test_sub_port_intf.py:86>, <TracebackEntry /agent/_work/1/s/sonic-swss/tests/test_sub_port_intf.py:393>]
test_nonflaky_dummy passed 1 out of the required 1 times. Success!

stephenxs avatar Apr 04 '24 00:04 stephenxs

/azpw run

stephenxs avatar Apr 04 '24 00:04 stephenxs

/AzurePipelines run

mssonicbld avatar Apr 04 '24 00:04 mssonicbld

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Apr 04 '24 00:04 azure-pipelines[bot]

@kcudnik @prsunny Could you help to merge this PR? Thanks

stephenxs avatar Apr 30 '24 01:04 stephenxs

@kcudnik could you please help to merge?

liat-grozovik avatar Apr 30 '24 17:04 liat-grozovik

Thanks @saiarcot895 for merging. @kcudnik fyi - needed to unblock an swss log issue.

prsunny avatar May 02 '24 22:05 prsunny

Do you need my help ?

kcudnik avatar May 03 '24 06:05 kcudnik

Do you need my help ?

no, we are good

prsunny avatar May 03 '24 16:05 prsunny