sonic-platform-daemons icon indicating copy to clipboard operation
sonic-platform-daemons copied to clipboard

Refactor ledd daemon and fix high CPU usage due to unexpected socket …

Open prgeor opened this issue 1 year ago • 3 comments
trafficstars

…close

Description

[ledd] Refactor ledd daemon and fix high CPU usage due to unexpected redis DB socket close

Motivation and Context

For unkown reason if redis closes the socket, then ledd daemon is continuously busy waiting for socket event and failing all the time. This is resulting in high CPI

How Has This Been Tested?

Close the socket abruptly and see ledd daemon is respawned so that new socket connection is established to redis DB without causing high CPU

Additional Information (Optional)

prgeor avatar Oct 10 '24 21:10 prgeor

@Staphylo could you please help review?

prgeor avatar Oct 10 '24 21:10 prgeor

@assrinivasan @vvolam please review

prgeor avatar Oct 17 '24 23:10 prgeor

@prgeor nit: spelling issue in PR description.

image

Also, could you fix the build failure?

vvolam avatar Oct 18 '24 20:10 vvolam

/azp run

mssonicbld avatar Feb 15 '25 19:02 mssonicbld

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Feb 15 '25 19:02 azure-pipelines[bot]

/azp run

mssonicbld avatar Feb 15 '25 20:02 mssonicbld

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Feb 15 '25 20:02 azure-pipelines[bot]

@prgeor nit: spelling issue in PR description.

image

Also, could you fix the build failure?

@vvolam fixed

prgeor avatar Feb 15 '25 23:02 prgeor

/azp run

mssonicbld avatar Mar 23 '25 06:03 mssonicbld

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Mar 23 '25 06:03 azure-pipelines[bot]

/azp run

mssonicbld avatar Mar 26 '25 03:03 mssonicbld

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Mar 26 '25 03:03 azure-pipelines[bot]

@davidm-arista @bobbymcgonigle can someone review this PR?

prgeor avatar Apr 04 '25 17:04 prgeor

/azp run

mssonicbld avatar Apr 22 '25 16:04 mssonicbld

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Apr 22 '25 16:04 azure-pipelines[bot]

/azp run

mssonicbld avatar Apr 22 '25 16:04 mssonicbld

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Apr 22 '25 16:04 azure-pipelines[bot]

/azp run

mssonicbld avatar Apr 22 '25 22:04 mssonicbld

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Apr 22 '25 22:04 azure-pipelines[bot]

/azp run

mssonicbld avatar Apr 23 '25 02:04 mssonicbld

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Apr 23 '25 02:04 azure-pipelines[bot]

/azp run

mssonicbld avatar Apr 23 '25 22:04 mssonicbld

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Apr 23 '25 22:04 azure-pipelines[bot]