sonic-platform-common
sonic-platform-common copied to clipboard
sonic-net
Support new ssd model Virtium VTSM24ABXI160-BM110006
Description
The ID of "Remaining Life Left" attribute on 'Virtium VTSM24ABXI160-BM110006' device is 231. However, it is not recognized by SmartCmd nor smartctl so far so we need to parse it using the ID number. Also add a unit for this model
Motivation and Context
The Virtium prefix of the device model is shown from smartctl output, so keep it.
How Has This Been Tested?
unit test and real hardware test show platform ssdhealth Device Model : Virtium VTSM24ABXI160-BM110006 Health : 100.0% Temperature : 52C
Additional Information (Optional)
Consider:
Refactor this function so that:
first check if current disk is one of the special Virtium SSD models, if so:
parse attribute 231 directly and exit
else (all other Virtium models) :
check for presence of NAND endurance and Avg erase count in the output
if present: get health that way else: health = N/A
What do you think?
Consider:
Refactor this function so that:
first check if current disk is one of the special Virtium SSD models, if so:
parse attribute 231 directly and exit
else (all other Virtium models) :
check for presence of NAND endurance and Avg erase count in the output
if present: get health that way else: health = N/A
What do you think?
LGTM, I had rework the pr as you suggested, please help to review :-)
Cherry-pick PR to 202405: https://github.com/sonic-net/sonic-platform-common/pull/516
