sonic-platform-common icon indicating copy to clipboard operation
sonic-platform-common copied to clipboard

[Transceiver] Porting back parser for QSFP-DD cable type and dictionaries for QSFP-DD codes to 201811 branch

Open mudsut4ke opened this issue 4 years ago • 11 comments

[Transceiver] Add parser for QSFP-DD cable type and dictionaries for QSFP-DD codes

Picking a change from: https://github.com/Azure/sonic-platform-common/commit/9e3c2da698f2063785e07c068fa3151dac3d5ca8

  • Add parser for QSFP-DD cable type.
  • Add dictionaries for QSFP-DD codes.

Test result: transceiver_info_dom.log

Signed-off-by: Wirut Getbamrung [email protected]

mudsut4ke avatar Sep 30 '20 10:09 mudsut4ke

Any other PR(s) depending on this PR for showing QSFP-DD DOM information? Can you add the test results for that info?

zhenggen-xu avatar Oct 05 '20 05:10 zhenggen-xu

Any other PR(s) depending on this PR for showing QSFP-DD DOM information? Can you add the test results for that info?

@zhenggen-xu , I think there is no depending on this PR for showing QSFP-DD DOM I can use this class with sfputil class to display QSFP-DD DOM

I have attached test results to in PR info already, please review it

mudsut4ke avatar Oct 05 '20 09:10 mudsut4ke

Any other PR(s) depending on this PR for showing QSFP-DD DOM information? Can you add the test results for that info?

@zhenggen-xu , I think there is no depending on this PR for showing QSFP-DD DOM I can use this class with sfputil class to display QSFP-DD DOM

I have attached test results to in PR info already, please review it

I guess my question is, can you give a pointer where the sfputil is using this class? and your test result is based on what SONiC version + this PR? Any other changes/PRs required?

zhenggen-xu avatar Oct 08 '20 22:10 zhenggen-xu

Any other PR(s) depending on this PR for showing QSFP-DD DOM information? Can you add the test results for that info?

@zhenggen-xu , I think there is no depending on this PR for showing QSFP-DD DOM I can use this class with sfputil class to display QSFP-DD DOM I have attached test results to in PR info already, please review it

I guess my question is, can you give a pointer where the sfputil is using this class? and your test result is based on what SONiC version + this PR? Any other changes/PRs required?

@zhenggen-xu , sfputil only use inf8628InterfaceId for decode eeprom of qsfp-dd device,

So I need this qsfpdd_dom to be a dom decoder on our device here is example : https://github.com/mudsut4ke/sonic-buildimage/pull/1046/files

mudsut4ke avatar Oct 09 '20 07:10 mudsut4ke

Any other PR(s) depending on this PR for showing QSFP-DD DOM information? Can you add the test results for that info?

@zhenggen-xu , I think there is no depending on this PR for showing QSFP-DD DOM I can use this class with sfputil class to display QSFP-DD DOM I have attached test results to in PR info already, please review it

I guess my question is, can you give a pointer where the sfputil is using this class? and your test result is based on what SONiC version + this PR? Any other changes/PRs required?

@zhenggen-xu , sfputil only use inf8628InterfaceId for decode eeprom of qsfp-dd device,

So I need this qsfpdd_dom to be a dom decoder on our device here is example : https://github.com/mudsut4ke/sonic-buildimage/pull/1046/files

OK, that was the PR I was looking for, it is depending on this one. For Silverstone platform, we should raise that PR against 201811, and it should link to this one in the description due to dependency.

zhenggen-xu avatar Oct 09 '20 17:10 zhenggen-xu

Any other PR(s) depending on this PR for showing QSFP-DD DOM information? Can you add the test results for that info?

@zhenggen-xu , I think there is no depending on this PR for showing QSFP-DD DOM I can use this class with sfputil class to display QSFP-DD DOM I have attached test results to in PR info already, please review it

I guess my question is, can you give a pointer where the sfputil is using this class? and your test result is based on what SONiC version + this PR? Any other changes/PRs required?

@zhenggen-xu , sfputil only use inf8628InterfaceId for decode eeprom of qsfp-dd device, So I need this qsfpdd_dom to be a dom decoder on our device here is example : https://github.com/mudsut4ke/sonic-buildimage/pull/1046/files

OK, that was the PR I was looking for, it is depending on this one. For Silverstone platform, we should raise that PR against 201811, and it should link to this one in the description due to dependency.

@zhenggen-xu , Sure, I will do

mudsut4ke avatar Oct 14 '20 04:10 mudsut4ke

Did you make any changes other than https://github.com/Azure/sonic-platform-common/pull/101? If not, we should cherry-pick that into 201811 without a new PR.

zhenggen-xu avatar Oct 19 '20 05:10 zhenggen-xu

@zhenggen-xu , no change I just cherry-pick commit from https://github.com/Azure/sonic-platform-common/pull/101

mudsut4ke avatar Oct 19 '20 07:10 mudsut4ke

@zhenggen-xu , Can you merge this one ?

mudsut4ke avatar Oct 26 '20 03:10 mudsut4ke

@lguohan: This PR introduces a new feature to the stable 201811 branch. What are your feelings?

jleveque avatar Nov 04 '20 18:11 jleveque

@mudsut4ke can we close this PR?

prgeor avatar Jul 27 '22 02:07 prgeor