sonic-platform-common
sonic-platform-common copied to clipboard
[Transceiver] Porting back parser for QSFP-DD cable type and dictionaries for QSFP-DD codes to 201811 branch
[Transceiver] Add parser for QSFP-DD cable type and dictionaries for QSFP-DD codes
Picking a change from: https://github.com/Azure/sonic-platform-common/commit/9e3c2da698f2063785e07c068fa3151dac3d5ca8
- Add parser for QSFP-DD cable type.
- Add dictionaries for QSFP-DD codes.
Test result: transceiver_info_dom.log
Signed-off-by: Wirut Getbamrung [email protected]
Any other PR(s) depending on this PR for showing QSFP-DD DOM information? Can you add the test results for that info?
Any other PR(s) depending on this PR for showing QSFP-DD DOM information? Can you add the test results for that info?
@zhenggen-xu , I think there is no depending on this PR for showing QSFP-DD DOM I can use this class with sfputil class to display QSFP-DD DOM
I have attached test results to in PR info already, please review it
Any other PR(s) depending on this PR for showing QSFP-DD DOM information? Can you add the test results for that info?
@zhenggen-xu , I think there is no depending on this PR for showing QSFP-DD DOM I can use this class with sfputil class to display QSFP-DD DOM
I have attached test results to in PR info already, please review it
I guess my question is, can you give a pointer where the sfputil is using this class? and your test result is based on what SONiC version + this PR? Any other changes/PRs required?
Any other PR(s) depending on this PR for showing QSFP-DD DOM information? Can you add the test results for that info?
@zhenggen-xu , I think there is no depending on this PR for showing QSFP-DD DOM I can use this class with sfputil class to display QSFP-DD DOM I have attached test results to in PR info already, please review it
I guess my question is, can you give a pointer where the sfputil is using this class? and your test result is based on what SONiC version + this PR? Any other changes/PRs required?
@zhenggen-xu , sfputil only use inf8628InterfaceId for decode eeprom of qsfp-dd device,
So I need this qsfpdd_dom to be a dom decoder on our device here is example : https://github.com/mudsut4ke/sonic-buildimage/pull/1046/files
Any other PR(s) depending on this PR for showing QSFP-DD DOM information? Can you add the test results for that info?
@zhenggen-xu , I think there is no depending on this PR for showing QSFP-DD DOM I can use this class with sfputil class to display QSFP-DD DOM I have attached test results to in PR info already, please review it
I guess my question is, can you give a pointer where the sfputil is using this class? and your test result is based on what SONiC version + this PR? Any other changes/PRs required?
@zhenggen-xu , sfputil only use inf8628InterfaceId for decode eeprom of qsfp-dd device,
So I need this qsfpdd_dom to be a dom decoder on our device here is example : https://github.com/mudsut4ke/sonic-buildimage/pull/1046/files
OK, that was the PR I was looking for, it is depending on this one. For Silverstone platform, we should raise that PR against 201811, and it should link to this one in the description due to dependency.
Any other PR(s) depending on this PR for showing QSFP-DD DOM information? Can you add the test results for that info?
@zhenggen-xu , I think there is no depending on this PR for showing QSFP-DD DOM I can use this class with sfputil class to display QSFP-DD DOM I have attached test results to in PR info already, please review it
I guess my question is, can you give a pointer where the sfputil is using this class? and your test result is based on what SONiC version + this PR? Any other changes/PRs required?
@zhenggen-xu , sfputil only use inf8628InterfaceId for decode eeprom of qsfp-dd device, So I need this qsfpdd_dom to be a dom decoder on our device here is example : https://github.com/mudsut4ke/sonic-buildimage/pull/1046/files
OK, that was the PR I was looking for, it is depending on this one. For Silverstone platform, we should raise that PR against 201811, and it should link to this one in the description due to dependency.
@zhenggen-xu , Sure, I will do
Did you make any changes other than https://github.com/Azure/sonic-platform-common/pull/101? If not, we should cherry-pick that into 201811 without a new PR.
@zhenggen-xu , no change I just cherry-pick commit from https://github.com/Azure/sonic-platform-common/pull/101
@zhenggen-xu , Can you merge this one ?
@lguohan: This PR introduces a new feature to the stable 201811 branch. What are your feelings?
@mudsut4ke can we close this PR?