sonic-mgmt icon indicating copy to clipboard operation
sonic-mgmt copied to clipboard

[test plan] 4-byte ASN community

Open Azarack opened this issue 2 years ago • 9 comments

Description of PR

Summary: Fixes # (issue) Adding test plan and test automation for 4-byte ASN community.

Type of change

  • [ ] Bug fix
  • [ ] Testbed and Framework(new/improvement)
  • [X] Test case(new/improvement)

Back port request

  • [ ] 201911
  • [ ] 202012
  • [ ] 202205

Approach

What is the motivation for this PR?

To perform the associated test

How did you do it?

Plan is in docs folder

How did you verify/test it?

Using pytest

Any platform specific information?

Neighbor devices must be sonic

Supported testbed topology if it's a new test case?

Tested on T2

Documentation

Azarack avatar Jun 22 '23 19:06 Azarack

@wenyiz2021 can you review this PR?

Azarack avatar Sep 29 '23 19:09 Azarack

@kishorekunal01 review

hasan-brcm avatar Oct 03 '23 21:10 hasan-brcm

The pre-commit check detected issues in the files touched by this pull request. The pre-commit check is a mandatory check, please fix detected issues.

Detailed pre-commit check results: trim trailing whitespace.................................................Failed
- hook id: trailing-whitespace
- exit code: 1
- files were modified by this hook

Fixing tests/bgp/test_4-byte_asn_community.py

fix end of files.........................................................Passed
check yaml...........................................(no files to check)Skipped
check for added large files..............................................Passed
check python ast.........................................................Passed
flake8...................................................................Passed
flake8...............................................(no files to check)Skipped
check conditional mark sort..........................(no files to check)Skipped

To run the pre-commit checks locally, you can follow below steps:

  1. Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt docker container.
  2. Ensure that the pre-commit package is installed:
sudo pip install pre-commit
  1. Go to repository root folder
  2. Install the pre-commit hooks:
pre-commit install
  1. Use pre-commit to check staged file:
pre-commit
  1. Alternatively, you can check committed files using:
pre-commit run --from-ref <commit_id> --to-ref <commit_id>

mssonicbld avatar Mar 06 '24 15:03 mssonicbld

The pre-commit check detected issues in the files touched by this pull request. The pre-commit check is a mandatory check, please fix detected issues.

Detailed pre-commit check results: trim trailing whitespace.................................................Failed
- hook id: trailing-whitespace
- exit code: 1
- files were modified by this hook

Fixing tests/bgp/test_4-byte_asn_community.py

fix end of files.........................................................Passed
check yaml...........................................(no files to check)Skipped
check for added large files..............................................Passed
check python ast.........................................................Passed
flake8...................................................................Passed
flake8...............................................(no files to check)Skipped
check conditional mark sort..........................(no files to check)Skipped

To run the pre-commit checks locally, you can follow below steps:

  1. Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt docker container.
  2. Ensure that the pre-commit package is installed:
sudo pip install pre-commit
  1. Go to repository root folder
  2. Install the pre-commit hooks:
pre-commit install
  1. Use pre-commit to check staged file:
pre-commit
  1. Alternatively, you can check committed files using:
pre-commit run --from-ref <commit_id> --to-ref <commit_id>

mssonicbld avatar Mar 06 '24 15:03 mssonicbld

@hasan-brcm @kishorekunal01 Hello, can you please look at the updates I have made as per your comments?

Azarack avatar Apr 04 '24 18:04 Azarack

/azpw run

wenyiz2021 avatar Apr 10 '24 18:04 wenyiz2021

/azp run

judyjoseph avatar Apr 10 '24 18:04 judyjoseph

@Azarack please fix the PR check failures

wenyiz2021 avatar Apr 10 '24 22:04 wenyiz2021

@wenyiz2021 All checks have now passed.

Azarack avatar Apr 11 '24 17:04 Azarack

@wenyiz2021 can you review, please?

Azarack avatar May 02 '24 19:05 Azarack

LGTM. @hasan-brcm @kishorekunal01 for review if your comments are resolved

wenyiz2021 avatar May 03 '24 06:05 wenyiz2021