sonic-mgmt
sonic-mgmt copied to clipboard
fix test failures caused due to PR 6519
Description of PR
Removed the duplicate entry for skip conditions for the following tests caused by https://github.com/sonic-net/sonic-mgmt/pull/6519
platform_tests/api/test_fan_drawer_fans.py::TestFanDrawerFans::test_set_fans_speed: platform_tests/api/test_chassis_fans.py::TestChassisFans::test_set_fans_speed: platform_tests/api/test_chassis_fans.py::TestChassisFans::test_set_fans_led:
Summary: Fixes # (6811)
Type of change
- [ x] Bug fix
- [ ] Testbed and Framework(new/improvement)
- [ ] Test case(new/improvement)
Back port request
- [ ] 201911
- [ ] 202012
- [ x] 202205
Approach
What is the motivation for this PR?
tests failures caused by https://github.com/sonic-net/sonic-mgmt/pull/6519
How did you do it?
Removed the duplicate entry for skip conditions
The committers listed above are authorized under a signed CLA.
- :white_check_mark: login: rraguraj / name: Ramsiddarth (a7b426f317809f73e73dfe60fda211451c49bff2)
The pre-commit check detected issues in the files touched by this pull request. The detected issues may be old or new. For new issues, please try to fix them.
For old issues, it is not mandatory to fix them because they were not caused by this change. It is unfair to blame author of this pull request. But if you can take extra effort to fix the old issues as well, that would be great!
Detailed pre-commit check results:
trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
check yaml...............................................................Failed
- hook id: check-yaml
- exit code: 1
while constructing a mapping
in "tests/common/plugins/conditional_mark/tests_mark_conditions_platform_tests.yaml", line 4, column 1
found duplicate key "platform_tests/api/test_chassis.py::TestChassisApi::test_get_watchdog" with value "{}" (original value: "{}")
in "tests/common/plugins/conditional_mark/tests_mark_conditions_platform_tests.yaml", line 68, column 1
To suppress this check see:
http://yaml.readthedocs.io/en/latest/api.html#duplicate-keys
check for added large files..............................................Passed
check python ast.....................................(no files to check)Skipped
flake8...............................................(no files to check)Skipped
To run the pre-commit checks locally, you can follow below steps:
- Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt docker container.
- Ensure that the
pre-commit
package is installed:
sudo pip install pre-commit
- Go to repository root folder
- Install the pre-commit hooks:
pre-commit install
- Use pre-commit to check staged file:
pre-commit
- Alternatively, you can check committed files using:
pre-commit run --from-ref <commit_id> --to-ref <commit_id>
please resolve the conflict.
add more description as what is the issue here.
@assrinivasan for viz.
please resolve the conflict.
please resolve the conflict
cc @gechiang for viz
@vperumal please help in resolving the conflict at earliest.
azp/run
/azp run
Azure Pipelines successfully started running 1 pipeline(s).
@abdosi Is the pre-commit-check failure ok to fail and not mandatory to pass? Changes looks good to me.
@gechiang @abdosi : Appreciate if you can expedite the double commit of this PR into 202205.