sonic-mgmt icon indicating copy to clipboard operation
sonic-mgmt copied to clipboard

[202012] vxlan+bfd test automation

Open rraghav-cisco opened this issue 3 years ago • 5 comments

Pulling the VxLAN+BFD code from master to 202012 branch.

rraghav-cisco avatar Nov 11 '22 06:11 rraghav-cisco

This pull request introduces 3 alerts and fixes 12 when merging 385d091a2c0ee078eefe2a1d568b3c3b4010b848 into c68b24d22a7b742aba7371dd275a7b15db714a2e - view on LGTM.com

new alerts:

  • 2 for Except block handles 'BaseException'
  • 1 for Unused local variable

fixed alerts:

  • 5 for Unused local variable
  • 4 for Unused import
  • 1 for Constant in conditional expression or statement
  • 1 for Testing equality to None
  • 1 for Comparison of constants

lgtm-com[bot] avatar Nov 11 '22 06:11 lgtm-com[bot]

@siqbal1986 , @ihorchekh pls review/comment/approve.

Thanks, rraghav

rraghav-cisco avatar Nov 11 '22 18:11 rraghav-cisco

This pull request introduces 3 alerts and fixes 12 when merging 37d2219a293875d67308d720e5f45a7187d5b4b5 into f24a9fa59d7922f2fbe13eb67533b97371bddf90 - view on LGTM.com

new alerts:

  • 2 for Except block handles 'BaseException'
  • 1 for Unused local variable

fixed alerts:

  • 5 for Unused local variable
  • 4 for Unused import
  • 1 for Constant in conditional expression or statement
  • 1 for Testing equality to None
  • 1 for Comparison of constants

lgtm-com[bot] avatar Nov 11 '22 22:11 lgtm-com[bot]

@rraghav-cisco, I see there are few other files missing from original PR #6212. @siqbal1986 , could you please review and merge?

prsunny avatar Nov 11 '22 22:11 prsunny

@rraghav-cisco, I see there are few other files missing from original PR #6212. @siqbal1986 , could you please review and merge?

@prsunny , yes, they are not needed for vxlan+bfd test script.

rraghav-cisco avatar Nov 11 '22 22:11 rraghav-cisco

This pull request introduces 3 alerts and fixes 12 when merging 5d21d8b14127f7bcf3e928efe0e6be4822d8aadc into 3d8329a5b74e770eb095d6276006c3d18050bd63 - view on LGTM.com

new alerts:

  • 2 for Except block handles 'BaseException'
  • 1 for Unused local variable

fixed alerts:

  • 5 for Unused local variable
  • 4 for Unused import
  • 1 for Constant in conditional expression or statement
  • 1 for Testing equality to None
  • 1 for Comparison of constants

Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. Please enable GitHub code scanning, which uses the same CodeQL engine :gear: that powers LGTM.com. For more information, please check out our post on the GitHub blog.

lgtm-com[bot] avatar Nov 15 '22 02:11 lgtm-com[bot]