sonic-mgmt icon indicating copy to clipboard operation
sonic-mgmt copied to clipboard

Added back correct ixia/pfc import statements that were removed

Open developfast opened this issue 2 years ago • 1 comments

Signed-off-by: dojha [email protected]

Description of PR

Summary: Added back the correct import statements of pytest fixtures that were removed earlier from #5928 Fixes # (issue)

Type of change

  • [x] Bug fix
  • [ ] Testbed and Framework(new/improvement)
  • [ ] Test case(new/improvement)

Back port request

  • [ ] 201911
  • [ ] 202012
  • [ ] 202205

Approach

What is the motivation for this PR?

When running ixia test cases in test_pfc_pause_lossless.py, the tests were failing due to missing imports

How did you do it?

Added import statements

How did you verify/test it?

Ran ixia tests on DUT

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

developfast avatar Nov 08 '22 21:11 developfast

The pre-commit check detected issues in the files touched by this pull request. The detected issues may be old or new. For new issues, please try to fix them.

For old issues, it is not mandatory to fix them because they were not caused by this change. It is unfair to blame author of this pull request. But if you can take extra effort to fix the old issues as well, that would be great!

Detailed pre-commit check results: trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
check yaml...........................................(no files to check)Skipped
check for added large files..............................................Passed
check python ast.........................................................Passed
flake8...................................................................Failed
- hook id: flake8
- exit code: 1

tests/ixia/pfc/test_pfc_pause_lossless.py:7:1: F401 'tests.common.fixtures.conn_graph_facts.conn_graph_facts' imported but unused
tests/ixia/pfc/test_pfc_pause_lossless.py:7:1: F401 'tests.common.fixtures.conn_graph_facts.fanout_graph_facts' imported but unused
tests/ixia/pfc/test_pfc_pause_lossless.py:9:1: F401 'tests.common.ixia.ixia_fixtures.ixia_api_serv_ip' imported but unused
tests/ixia/pfc/test_pfc_pause_lossless.py:9:1: F401 'tests.common.ixia.ixia_fixtures.ixia_api_serv_port' imported but unused
tests/ixia/pfc/test_pfc_pause_lossless.py:9:1: F401 'tests.common.ixia.ixia_fixtures.ixia_api_serv_user' imported but unused
tests/ixia/pfc/test_pfc_pause_lossless.py:9:1: F401 'tests.common.ixia.ixia_fixtures.ixia_api_serv_passwd' imported but unused
tests/ixia/pfc/test_pfc_pause_lossless.py:9:1: F401 'tests.common.ixia.ixia_fixtures.ixia_api' imported but unused
tests/ixia/pfc/test_pfc_pause_lossless.py:9:1: F401 'tests.common.ixia.ixia_fixtures.ixia_testbed_config' imported but unused
tests/ixia/pfc/test_pfc_pause_lossless.py:11:1: F401 'tests.common.ixia.qos_fixtures.prio_dscp_map' imported but unused
tests/ixia/pfc/test_pfc_pause_lossless.py:11:1: F401 'tests.common.ixia.qos_fixtures.all_prio_list' imported but unused
tests/ixia/pfc/test_pfc_pause_lossless.py:11:1: F401 'tests.common.ixia.qos_fixtures.lossless_prio_list' imported but unused
...
[truncated extra lines, please run pre-commit locally to view full check results]

To run the pre-commit checks locally, you can follow below steps:

  1. Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt docker container.
  2. Ensure that the pre-commit package is installed:
sudo pip install pre-commit
  1. Go to repository root folder
  2. Install the pre-commit hooks:
pre-commit install
  1. Use pre-commit to check staged file:
pre-commit
  1. Alternatively, you can check committed files using:
pre-commit run --from-ref <commit_id> --to-ref <commit_id>

azure-pipelines[bot] avatar Nov 08 '22 21:11 azure-pipelines[bot]