Remove ping_all_neighbors since neighbor can be pinged only from the …

[mannytaheri]

…connected ASIC when eBGP is down

Description of PR

test_neighbor_hw_mac_change and test_gratarp_macchange testcases try to ping_all_neighbors from all the asics but ping fails because eBGP to the neighbor is down. A neighbor can be pinged only from the connected ASIC when eBGP is down and this is already done in the same testcases.0 Therefore, Removing ping_all_neighbors from both testcases.

Summary: Fixes # (issue)

Type of change

• [ ] Bug fix
• [ ] Testbed and Framework(new/improvement)
• [x ] Test case(new/improvement)

Back port request

• [ ] 201911
• [ ] 202012
• [ ] 202205

Approach

What is the motivation for this PR?

Remove ping_all_neighbors since neighbor can be pinged only from the connected ASIC when eBGP is down.

How did you do it?

Removed ping_all_neighbors from test_neighbor_hw_mac_change testcase. Removed ping_all_neighbors from test_gratarp_macchange testcase.

How did you verify/test it?

Tested test_neighbor_hw_mac_change and test_gratarp_macchange in a multi ASIC chassis

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

[azure-pipelines[bot]]

The pre-commit check detected issues in the files touched by this pull request. The detected issues may be old or new. For new issues, please try to fix them.

For old issues, it is not mandatory to fix them because they were not caused by this change. It is unfair to blame author of this pull request. But if you can take extra effort to fix the old issues as well, that would be great!

Detailed pre-commit check results: trim trailing whitespace.................................................Passed
fix end of files.........................................................Failed
- hook id: end-of-file-fixer
- exit code: 1
- files were modified by this hook

Fixing tests/voq/test_voq_nbr.py

check yaml...........................................(no files to check)Skipped
check for added large files..............................................Passed
check python ast.........................................................Passed
flake8...................................................................Failed
- hook id: flake8
- exit code: 1

tests/voq/test_voq_nbr.py:29:1: F401 'tests.common.fixtures.ptfhost_utils.copy_ptftests_directory' imported but unused
tests/voq/test_voq_nbr.py:762:121: E501 line too long (121 > 120 characters)
tests/voq/test_voq_nbr.py:807:1: E303 too many blank lines (3)
tests/voq/test_voq_nbr.py:902:1: E303 too many blank lines (3)
tests/voq/test_voq_nbr.py:934:121: E501 line too long (133 > 120 characters)
...
[truncated extra lines, please run pre-commit locally to view full check results]

To run the pre-commit checks locally, you can follow below steps:

1. Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt docker container.
2. Ensure that the pre-commit package is installed:

sudo pip install pre-commit

3. Go to repository root folder
4. Install the pre-commit hooks:

pre-commit install

5. Use pre-commit to check staged file:

pre-commit

6. Alternatively, you can check committed files using:

pre-commit run --from-ref <commit_id> --to-ref <commit_id>

[azure-pipelines[bot]]

The pre-commit check detected issues in the files touched by this pull request. The detected issues may be old or new. For new issues, please try to fix them.

For old issues, it is not mandatory to fix them because they were not caused by this change. It is unfair to blame author of this pull request. But if you can take extra effort to fix the old issues as well, that would be great!

Detailed pre-commit check results: trim trailing whitespace.................................................Passed
fix end of files.........................................................Failed
- hook id: end-of-file-fixer
- exit code: 1
- files were modified by this hook

Fixing tests/voq/test_voq_nbr.py

check yaml...........................................(no files to check)Skipped
check for added large files..............................................Passed
check python ast.........................................................Passed
flake8...................................................................Failed
- hook id: flake8
- exit code: 1

tests/voq/test_voq_nbr.py:29:1: F401 'tests.common.fixtures.ptfhost_utils.copy_ptftests_directory' imported but unused
tests/voq/test_voq_nbr.py:762:121: E501 line too long (121 > 120 characters)
tests/voq/test_voq_nbr.py:807:1: E303 too many blank lines (3)
tests/voq/test_voq_nbr.py:902:1: E303 too many blank lines (3)
tests/voq/test_voq_nbr.py:934:121: E501 line too long (133 > 120 characters)
...
[truncated extra lines, please run pre-commit locally to view full check results]

To run the pre-commit checks locally, you can follow below steps:

1. Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt docker container.
2. Ensure that the pre-commit package is installed:

sudo pip install pre-commit

3. Go to repository root folder
4. Install the pre-commit hooks:

pre-commit install

5. Use pre-commit to check staged file:

pre-commit

6. Alternatively, you can check committed files using:

pre-commit run --from-ref <commit_id> --to-ref <commit_id>