sonic-mgmt icon indicating copy to clipboard operation
sonic-mgmt copied to clipboard

Add Arista M0 devices to copp_tests M0 device list

Open veronica-arista opened this issue 1 year ago • 1 comments

Description of PR

PR https://github.com/sonic-net/sonic-mgmt/pull/12836 changed the copp policer limit for some traffic classes from 300 to 100 for all DUTs except M0. Add Arista M0 devices to the test's M0 list.

Summary: Fixes # (issue)

Type of change

  • [x] Bug fix
  • [ ] Testbed and Framework(new/improvement)
  • [ ] Test case(new/improvement)

Back port request

  • [ ] 202012
  • [ ] 202205
  • [ ] 202305
  • [x] 202311
  • [x] 202405

Approach

What is the motivation for this PR?

Copp tests were failing on Arista M0 devices due to the policer limit change.

How did you do it?

How did you verify/test it?

Copp tests pass on Arista M0 devices with this fix.

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

veronica-arista avatar Sep 05 '24 20:09 veronica-arista

The pre-commit check detected issues in the files touched by this pull request. The pre-commit check is a mandatory check, please fix detected issues.

Detailed pre-commit check results: trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
check yaml...........................................(no files to check)Skipped
check for added large files..............................................Passed
check python ast.........................................................Passed
flake8...................................................................Failed
- hook id: flake8
- exit code: 1

ansible/roles/test/files/ptftests/py3/copp_tests.py:350:71: E231 missing whitespace after ','
ansible/roles/test/files/ptftests/py3/copp_tests.py:394:71: E231 missing whitespace after ','
ansible/roles/test/files/ptftests/py3/copp_tests.py:457:71: E231 missing whitespace after ','
ansible/roles/test/files/ptftests/py3/copp_tests.py:488:71: E231 missing whitespace after ','

flake8...............................................(no files to check)Skipped
check conditional mark sort..........................(no files to check)Skipped

To run the pre-commit checks locally, you can follow below steps:

  1. Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt docker container.
  2. Ensure that the pre-commit package is installed:
sudo pip install pre-commit
  1. Go to repository root folder
  2. Install the pre-commit hooks:
pre-commit install
  1. Use pre-commit to check staged file:
pre-commit
  1. Alternatively, you can check committed files using:
pre-commit run --from-ref <commit_id> --to-ref <commit_id>

mssonicbld avatar Sep 05 '24 20:09 mssonicbld

hi @Blueve could you help to review?

StormLiangMS avatar Sep 12 '24 04:09 StormLiangMS

@StormLiangMS this PR can be closed as the issue has been addressed by https://github.com/sonic-net/sonic-mgmt/pull/14627/files

Blueve avatar Oct 18 '24 07:10 Blueve