sonic-mgmt icon indicating copy to clipboard operation
sonic-mgmt copied to clipboard

[action] [PR:12346] [test_po_cleanup] Do a safe config reload

Open mssonicbld opened this issue 1 year ago • 17 comments

Description of PR

Summary: Fixes # (issue)

Type of change

  • [x] Bug fix
  • [ ] Testbed and Framework(new/improvement)
  • [ ] Test case(new/improvement)

Back port request

  • [ ] 201911
  • [ ] 202012
  • [ ] 202205
  • [ ] 202305
  • [ ] 202311

Approach

What is the motivation for this PR?

For test_po_cleanup and test_po_cleanup_after_reload, do a safe reload and wait for BGP to come up. This makes sure that the next test case that runs gets the testbed in a good, stable state.

This is particularly needed on slow-CPU devices where a proper config reload will take some time to run.

How did you do it?

How did you verify/test it?

Verified that two runs of pc/test_po_cleanup.py on MSN2700 passed. This doesn't necessarily guarantee it won't ever fail because of this error, though, since it seems to be somewhat flaky.

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

mssonicbld avatar Aug 28 '24 04:08 mssonicbld

Original PR: https://github.com/sonic-net/sonic-mgmt/pull/12346

mssonicbld avatar Aug 28 '24 04:08 mssonicbld

/azp run Azure.sonic-mgmt

mssonicbld avatar Sep 02 '24 01:09 mssonicbld

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Sep 02 '24 01:09 azure-pipelines[bot]

/azp run Azure.sonic-mgmt

mssonicbld avatar Sep 03 '24 01:09 mssonicbld

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Sep 03 '24 01:09 azure-pipelines[bot]

/azp run Azure.sonic-mgmt

mssonicbld avatar Sep 04 '24 01:09 mssonicbld

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Sep 04 '24 01:09 azure-pipelines[bot]

/azp run Azure.sonic-mgmt

mssonicbld avatar Sep 05 '24 01:09 mssonicbld

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Sep 05 '24 01:09 azure-pipelines[bot]

/azp run Azure.sonic-mgmt

mssonicbld avatar Sep 06 '24 01:09 mssonicbld

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Sep 06 '24 01:09 azure-pipelines[bot]

/azp run Azure.sonic-mgmt

mssonicbld avatar Sep 07 '24 01:09 mssonicbld

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Sep 07 '24 01:09 azure-pipelines[bot]

/azp run Azure.sonic-mgmt

mssonicbld avatar Sep 09 '24 01:09 mssonicbld

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Sep 09 '24 01:09 azure-pipelines[bot]

/azp run Azure.sonic-mgmt

mssonicbld avatar Sep 10 '24 01:09 mssonicbld

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Sep 10 '24 01:09 azure-pipelines[bot]

/azp run Azure.sonic-mgmt

mssonicbld avatar Sep 14 '24 01:09 mssonicbld

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Sep 14 '24 01:09 azure-pipelines[bot]

/azp run Azure.sonic-mgmt

mssonicbld avatar Sep 17 '24 01:09 mssonicbld

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Sep 17 '24 01:09 azure-pipelines[bot]

/azp run Azure.sonic-mgmt

mssonicbld avatar Nov 09 '24 01:11 mssonicbld

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Nov 09 '24 01:11 azure-pipelines[bot]

/azp run Azure.sonic-mgmt

mssonicbld avatar Nov 12 '24 01:11 mssonicbld

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Nov 12 '24 01:11 azure-pipelines[bot]

/azp run Azure.sonic-mgmt

mssonicbld avatar Jan 16 '25 01:01 mssonicbld

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Jan 16 '25 01:01 azure-pipelines[bot]

/azp run Azure.sonic-mgmt

mssonicbld avatar Jan 17 '25 01:01 mssonicbld

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Jan 17 '25 01:01 azure-pipelines[bot]

/azp run Azure.sonic-mgmt

mssonicbld avatar Jan 18 '25 01:01 mssonicbld