sonic-mgmt icon indicating copy to clipboard operation
sonic-mgmt copied to clipboard

Reg: Everflow New TC bkg traffic https://github.com/sonic-net/sonic-mgmt/issues/13505

Open vikshaw-Nokia opened this issue 1 year ago • 2 comments

Description of PR

Summary: Ref: https://github.com/sonic-net/sonic-mgmt/issues/13505 A New Test Case is added to verify other background traffic is not getting mirrored.

Type of change

  • [ ] Bug fix
  • [ ] Testbed and Framework(new/improvement)
  • [X] Test case(new/improvement)

Back port request

  • [ ] 202012
  • [ ] 202205
  • [ ] 202305
  • [ ] 202311
  • [x] 202405

Approach

What is the motivation for this PR?

Ref: https://github.com/sonic-net/sonic-mgmt/issues/13505

How did you do it?

Added a New Test Case to ensure the background traffic is not getting mirrored

How did you verify/test it?

Tested on T2 VOQ Chassis

Any platform specific information?

Supported testbed topology if it's a new test case?

No Changes to existing use case

Documentation

vikshaw-Nokia avatar Aug 26 '24 22:08 vikshaw-Nokia

The pre-commit check detected issues in the files touched by this pull request. The pre-commit check is a mandatory check, please fix detected issues.

Detailed pre-commit check results: trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
check yaml...........................................(no files to check)Skipped
check for added large files..............................................Passed
check python ast.........................................................Passed
flake8...................................................................Failed
- hook id: flake8
- exit code: 1

tests/everflow/test_everflow_testbed.py:649:47: F811 redefinition of unused 'setup_info' from line 17
tests/everflow/test_everflow_testbed.py:651:41: F811 redefinition of unused 'skip_traffic_test' from line 16

flake8...............................................(no files to check)Skipped
check conditional mark sort..........................(no files to check)Skipped

To run the pre-commit checks locally, you can follow below steps:

  1. Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt docker container.
  2. Ensure that the pre-commit package is installed:
sudo pip install pre-commit
  1. Go to repository root folder
  2. Install the pre-commit hooks:
pre-commit install
  1. Use pre-commit to check staged file:
pre-commit
  1. Alternatively, you can check committed files using:
pre-commit run --from-ref <commit_id> --to-ref <commit_id>

mssonicbld avatar Aug 26 '24 22:08 mssonicbld

@arlakshm @abdosi Hello, Have added verification for V6 and verification for background traffic as well. Please Verify & Review

Regards.

vikshaw-Nokia avatar Sep 06 '24 15:09 vikshaw-Nokia

@wangxin can we please approve the request for 202405? thanks.

rlhui avatar Oct 07 '24 20:10 rlhui

@vikshaw-Nokia , @arlakshm , since the test gap is only for Chassis, do we need to add this enhancement to all roles?

bingwang-ms avatar Nov 04 '24 22:11 bingwang-ms