sonic-mgmt
sonic-mgmt copied to clipboard
Add qos_params.th5.yaml
Description of PR
Adds static parameters for TH5 QoS tests
Summary: Fixes # (issue)
Type of change
- [x] Bug fix
Back port request
- [x] 202311
- [x] 202405
Approach
What is the motivation for this PR?
Adds a baseline of parameters, which fixes the headroom pool size test.
How did you do it?
Values were generated by updated version of the generator script.
How did you verify/test it?
Manual test runs.
Rick is going to update this PR with latest parameter and test changes here. Then we will get it reviewed and merged.
Moved this back to draft for a moment. There's an intermittent failure in one of the test cases due to the margin being 0. I'll update this PR after running the tests locally a few times to verify adding a small margin fixes this.
@Janetxxx , do you mind to cherry pick this PR to our test branch? This should get the qos tests fixed.
@Janetxxx , do you mind to cherry pick this PR to our test branch? This should get the qos tests fixed. @r12f Done!
@Janetxxx I've pushed another small fix that fixes flaky failures in testQosSaiHeadroomPoolWatermark
The pre-commit check detected issues in the files touched by this pull request. The pre-commit check is a mandatory check, please fix detected issues.
Detailed pre-commit check results:
trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
check yaml...............................................................Passed
check for added large files..............................................Passed
check python ast.........................................................Passed
flake8...................................................................Failed
- hook id: flake8
- exit code: 1
tests/qos/test_qos_sai.py:2110:29: F821 undefined name 'qosConfigWrr'
flake8...............................................(no files to check)Skipped
check conditional mark sort..............................................Passed
To run the pre-commit checks locally, you can follow below steps:
- Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt docker container.
- Ensure that the
pre-commitpackage is installed:
sudo pip install pre-commit
- Go to repository root folder
- Install the pre-commit hooks:
pre-commit install
- Use pre-commit to check staged file:
pre-commit
- Alternatively, you can check committed files using:
pre-commit run --from-ref <commit_id> --to-ref <commit_id>
The pre-commit check detected issues in the files touched by this pull request. The pre-commit check is a mandatory check, please fix detected issues.
Detailed pre-commit check results:
trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
check yaml...............................................................Passed
check for added large files..............................................Passed
check python ast.........................................................Passed
flake8...................................................................Failed
- hook id: flake8
- exit code: 1
tests/saitests/py3/sai_qos_tests.py:3792:27: E221 multiple spaces before operator
tests/saitests/py3/sai_qos_tests.py:3794:41: E221 multiple spaces before operator
flake8...............................................(no files to check)Skipped
check conditional mark sort..............................................Passed
To run the pre-commit checks locally, you can follow below steps:
- Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt docker container.
- Ensure that the
pre-commitpackage is installed:
sudo pip install pre-commit
- Go to repository root folder
- Install the pre-commit hooks:
pre-commit install
- Use pre-commit to check staged file:
pre-commit
- Alternatively, you can check committed files using:
pre-commit run --from-ref <commit_id> --to-ref <commit_id>
The pre-commit check detected issues in the files touched by this pull request. The pre-commit check is a mandatory check, please fix detected issues.
Detailed pre-commit check results:
trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
check yaml...............................................................Passed
check for added large files..............................................Passed
check python ast.........................................................Passed
flake8...................................................................Failed
- hook id: flake8
- exit code: 1
tests/saitests/py3/sai_qos_tests.py:3794:27: E231 missing whitespace after ','
flake8...............................................(no files to check)Skipped
check conditional mark sort..............................................Passed
To run the pre-commit checks locally, you can follow below steps:
- Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt docker container.
- Ensure that the
pre-commitpackage is installed:
sudo pip install pre-commit
- Go to repository root folder
- Install the pre-commit hooks:
pre-commit install
- Use pre-commit to check staged file:
pre-commit
- Alternatively, you can check committed files using:
pre-commit run --from-ref <commit_id> --to-ref <commit_id>
/azpw run
/azp run
Azure Pipelines successfully started running 1 pipeline(s).
Cherry-pick PR to 202405: https://github.com/sonic-net/sonic-mgmt/pull/15900
Cherry-pick PR to 202311: https://github.com/sonic-net/sonic-mgmt/pull/15901