sonic-mgmt icon indicating copy to clipboard operation
sonic-mgmt copied to clipboard

Add qos_params.th5.yaml

Open rick-arista opened this issue 1 year ago • 5 comments

Description of PR

Adds static parameters for TH5 QoS tests

Summary: Fixes # (issue)

Type of change

  • [x] Bug fix

Back port request

  • [x] 202311
  • [x] 202405

Approach

What is the motivation for this PR?

Adds a baseline of parameters, which fixes the headroom pool size test.

How did you do it?

Values were generated by updated version of the generator script.

How did you verify/test it?

Manual test runs.

rick-arista avatar Aug 26 '24 18:08 rick-arista

Rick is going to update this PR with latest parameter and test changes here. Then we will get it reviewed and merged.

r12f avatar Sep 04 '24 21:09 r12f

Moved this back to draft for a moment. There's an intermittent failure in one of the test cases due to the margin being 0. I'll update this PR after running the tests locally a few times to verify adding a small margin fixes this.

rick-arista avatar Sep 17 '24 16:09 rick-arista

@Janetxxx , do you mind to cherry pick this PR to our test branch? This should get the qos tests fixed.

r12f avatar Sep 17 '24 23:09 r12f

@Janetxxx , do you mind to cherry pick this PR to our test branch? This should get the qos tests fixed. @r12f Done!

Janetxxx avatar Sep 18 '24 01:09 Janetxxx

@Janetxxx I've pushed another small fix that fixes flaky failures in testQosSaiHeadroomPoolWatermark

rick-arista avatar Sep 18 '24 04:09 rick-arista

The pre-commit check detected issues in the files touched by this pull request. The pre-commit check is a mandatory check, please fix detected issues.

Detailed pre-commit check results: trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
check yaml...............................................................Passed
check for added large files..............................................Passed
check python ast.........................................................Passed
flake8...................................................................Failed
- hook id: flake8
- exit code: 1

tests/qos/test_qos_sai.py:2110:29: F821 undefined name 'qosConfigWrr'

flake8...............................................(no files to check)Skipped
check conditional mark sort..............................................Passed

To run the pre-commit checks locally, you can follow below steps:

  1. Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt docker container.
  2. Ensure that the pre-commit package is installed:
sudo pip install pre-commit
  1. Go to repository root folder
  2. Install the pre-commit hooks:
pre-commit install
  1. Use pre-commit to check staged file:
pre-commit
  1. Alternatively, you can check committed files using:
pre-commit run --from-ref <commit_id> --to-ref <commit_id>

mssonicbld avatar Nov 14 '24 22:11 mssonicbld

The pre-commit check detected issues in the files touched by this pull request. The pre-commit check is a mandatory check, please fix detected issues.

Detailed pre-commit check results: trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
check yaml...............................................................Passed
check for added large files..............................................Passed
check python ast.........................................................Passed
flake8...................................................................Failed
- hook id: flake8
- exit code: 1

tests/saitests/py3/sai_qos_tests.py:3792:27: E221 multiple spaces before operator
tests/saitests/py3/sai_qos_tests.py:3794:41: E221 multiple spaces before operator

flake8...............................................(no files to check)Skipped
check conditional mark sort..............................................Passed

To run the pre-commit checks locally, you can follow below steps:

  1. Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt docker container.
  2. Ensure that the pre-commit package is installed:
sudo pip install pre-commit
  1. Go to repository root folder
  2. Install the pre-commit hooks:
pre-commit install
  1. Use pre-commit to check staged file:
pre-commit
  1. Alternatively, you can check committed files using:
pre-commit run --from-ref <commit_id> --to-ref <commit_id>

mssonicbld avatar Nov 22 '24 19:11 mssonicbld

The pre-commit check detected issues in the files touched by this pull request. The pre-commit check is a mandatory check, please fix detected issues.

Detailed pre-commit check results: trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
check yaml...............................................................Passed
check for added large files..............................................Passed
check python ast.........................................................Passed
flake8...................................................................Failed
- hook id: flake8
- exit code: 1

tests/saitests/py3/sai_qos_tests.py:3794:27: E231 missing whitespace after ','

flake8...............................................(no files to check)Skipped
check conditional mark sort..............................................Passed

To run the pre-commit checks locally, you can follow below steps:

  1. Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt docker container.
  2. Ensure that the pre-commit package is installed:
sudo pip install pre-commit
  1. Go to repository root folder
  2. Install the pre-commit hooks:
pre-commit install
  1. Use pre-commit to check staged file:
pre-commit
  1. Alternatively, you can check committed files using:
pre-commit run --from-ref <commit_id> --to-ref <commit_id>

mssonicbld avatar Nov 22 '24 19:11 mssonicbld

/azpw run

Janetxxx avatar Dec 03 '24 00:12 Janetxxx

/azp run

wangxin avatar Dec 03 '24 00:12 wangxin

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Dec 03 '24 00:12 azure-pipelines[bot]

Cherry-pick PR to 202405: https://github.com/sonic-net/sonic-mgmt/pull/15900

mssonicbld avatar Dec 05 '24 05:12 mssonicbld

Cherry-pick PR to 202311: https://github.com/sonic-net/sonic-mgmt/pull/15901

mssonicbld avatar Dec 05 '24 05:12 mssonicbld