sonic-mgmt icon indicating copy to clipboard operation
sonic-mgmt copied to clipboard

Test gap for lldp APPL_DB data consistency

Open ZhaohuiS opened this issue 1 year ago • 2 comments
trafficstars

Description of PR

Summary: Fixes # (issue) Address https://github.com/sonic-net/sonic-mgmt/issues/13937

ADO:28941599

Type of change

  • [ ] Bug fix
  • [ ] Testbed and Framework(new/improvement)
  • [ ] Test case(new/improvement)

Back port request

  • [ ] 202012
  • [ ] 202205
  • [ ] 202305
  • [x] 202311
  • [x] 202405

Approach

What is the motivation for this PR?

To address https://github.com/sonic-net/sonic-mgmt/issues/13937 Test plan: https://github.com/sonic-net/sonic-mgmt/pull/14080

How did you do it?

Add a new test script to test lldp APPL_DB data consistency

How did you verify/test it?

run lldp/test_lldp_syncd.py

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

ZhaohuiS avatar Aug 22 '24 14:08 ZhaohuiS

Hi, @ZhaohuiS , can you help me confirm if this new added test script can run in PR test?

yutongzhang-microsoft avatar Sep 03 '24 08:09 yutongzhang-microsoft

Hi, @ZhaohuiS , can you help me confirm if this new added test script can run in PR test?

@yutongzhang-microsoft It should be able to run on kvm testbed.

ZhaohuiS avatar Sep 09 '24 09:09 ZhaohuiS

@ZhaohuiS do we need it in 202405 branch?

yejianquan avatar Sep 14 '24 07:09 yejianquan

@ZhaohuiS PR conflicts with 202405 branch

mssonicbld avatar Sep 14 '24 07:09 mssonicbld

@ZhaohuiS PR conflicts with 202311 branch

mssonicbld avatar Sep 19 '24 12:09 mssonicbld

@ZhaohuiS The test case is failing with error .

  File "/var/src/sonic-mgmt_vms2-4-t0-2700_646f1405735219c3e54440f2/tests/lldp/test_lldp_syncd.py", line 36, in get_lldp_entry_content
    return db.hget_all("LLDP_ENTRY_TABLE:{}".format(interface))
AttributeError: 'SonicDbCli' object has no attribute 'hget_all'

Is there any dependent PR not merged?

bingwang-ms avatar Oct 04 '24 23:10 bingwang-ms

Issue fixed in PR https://github.com/sonic-net/sonic-mgmt/pull/14846

bingwang-ms avatar Oct 04 '24 23:10 bingwang-ms