sonic-mgmt
sonic-mgmt copied to clipboard
sonic-net
Update platform sfp tests to skip dom check for sfp with flat memory
Description of PR
- Sfp eeprom with option dom is not working on Xcvrs with flat memory. There is a relevant PR:https://github.com/sonic-net/sonic-utilities/pull/3385. Therefore, skip dom check for sfp with flat memory. Also, fix sonic mgmt issue: https://github.com/sonic-net/sonic-mgmt/issues/12981
- Skip test ports with flat memory for test_get_transceiver_bulk_status
Summary: Fixes # (issue)
Type of change
- [x] Bug fix
- [ ] Testbed and Framework(new/improvement)
- [ ] Test case(new/improvement)
Back port request
- [ ] 202012
- [ ] 202205
- [ ] 202305
- [ ] 202311
- [x] 202405
Approach
What is the motivation for this PR?
Fix issue： https://github.com/sonic-net/sonic-mgmt/issues/12981
How did you do it?
Skip dom checker for sfp with flat memory
How did you verify/test it?
run test_xcvr_info_in_db and test_check_sfp_eeprom_with_option_dom
Any platform specific information?
Any
Supported testbed topology if it's a new test case?
Documentation
![azure-pipelines[bot] avatar](https://avatars.githubusercontent.com/in/9426?v=4 "Published by a pub.dev verified publisher"){kind=small}
@JibinBao in your PR description you mentioned design change. Can you point me to the relevant design change PR?
@JibinBao in your PR description you mentioned design change. Can you point me to the relevant design change PR?
@prgeor , please check: https://github.com/sonic-net/sonic-utilities/pull/3385
Hi @mihirpat1 , I have fixed the comments, Could you please help review it again? Thanks
The pre-commit check detected issues in the files touched by this pull request. The pre-commit check is a mandatory check, please fix detected issues.
Detailed pre-commit check results:
trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
check yaml...........................................(no files to check)Skipped
check for added large files..............................................Passed
check python ast.........................................................Passed
flake8...................................................................Failed
- hook id: flake8
- exit code: 1
tests/platform_tests/conftest.py:12:1: E303 too many blank lines (3)
flake8...............................................(no files to check)Skipped
check conditional mark sort..........................(no files to check)Skipped
To run the pre-commit checks locally, you can follow below steps:
- Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt docker container.
- Ensure that the
pre-commitpackage is installed:
sudo pip install pre-commit
- Go to repository root folder
- Install the pre-commit hooks:
pre-commit install
- Use pre-commit to check staged file:
pre-commit
- Alternatively, you can check committed files using:
pre-commit run --from-ref <commit_id> --to-ref <commit_id>
@JibinBao Can you file a PR to 202405 to address conflict?
hi @bingwang-ms , Please review: https://github.com/sonic-net/sonic-mgmt/pull/15141/