sonic-mgmt icon indicating copy to clipboard operation
sonic-mgmt copied to clipboard

Multi-asic support for snmp_queue_counters test

Open sanjair-git opened this issue 1 year ago • 2 comments
trafficstars

Description of PR

Summary: Fixes # (issue)

  • Added multi-asic support for the test 'test_snmp_queue_counters' under snmp

Type of change

  • [ ] Bug fix
  • [ ] Testbed and Framework(new/improvement)
  • [x] Test case(new/improvement)

Back port request

  • [ ] 202012
  • [ ] 202205
  • [ ] 202305
  • [ ] 202311
  • [x] 202405

Approach

What is the motivation for this PR?

  • Currently, 'test_snmp_queue_counters' test doesn't have multi-asic support and the test is failing for multi-asic chassis due to the lack of support.

How did you do it?

  • Added multi-asic support for test 'test_snmp_queue_counters' and made sure the current test logic is not affected.

How did you verify/test it?

  • Ran the above-mentioned test case on a T2 chassis and verified.

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

sanjair-git avatar Jul 11 '24 18:07 sanjair-git

Ran the above test on multi-asic T2 chassis with all the above changes. Results attached. image

sanjair-git avatar Aug 01 '24 20:08 sanjair-git

@SuvarnaMeenakshi, can you sign-off on this PR?

arlakshm avatar Sep 03 '24 22:09 arlakshm

viz @kevinwangsk . Please merge this to 202405 branch.

rajendrat avatar Oct 21 '24 22:10 rajendrat

Cherry-pick PR to 202405: https://github.com/sonic-net/sonic-mgmt/pull/15220

mssonicbld avatar Oct 29 '24 01:10 mssonicbld

hi @sanjair-git could you help to take a look on the cherry pick PR, which has a PR test failure.

StormLiangMS avatar Nov 21 '24 04:11 StormLiangMS

hi @sanjair-git could you help to take a look on the cherry pick PR, which has a PR test failure.

Sure @StormLiangMS, I will take a look.

sanjair-git avatar Nov 21 '24 18:11 sanjair-git

hi @sanjair-git could you help to take a look on the cherry pick PR, which has a PR test failure.

Hi @StormLiangMS, for 202405 branch, the changes with the fix have been merged as part of #15735. Taken care.

sanjair-git avatar Nov 27 '24 18:11 sanjair-git