sonic-mgmt icon indicating copy to clipboard operation
sonic-mgmt copied to clipboard

Fix test_ecmp_hash_seed_value failure on 202311

Open ZhaohuiS opened this issue 7 months ago • 0 comments

Description of PR

Summary: Fixes # (issue) After code change https://github.com/sonic-net/sonic-buildimage/pull/18912 and https://github.com/sonic-net/sonic-mgmt/pull/13538, test_ecmp_sai_value is not xfailed on 202311, but test_ecmp_hash_seed_value consistently failed on 202311, since the sai_hash_seed_config_hash_offset_enable is not set in config.bcm, it's set by swss config on 202311 and later image.

Type of change

  • [ ] Bug fix
  • [ ] Testbed and Framework(new/improvement)
  • [ ] Test case(new/improvement)

Back port request

  • [ ] 202012
  • [ ] 202205
  • [ ] 202305
  • [x] 202311
  • [x] 202405

Approach

What is the motivation for this PR?

  1. Fix test_ecmp_hash_seed_value failure on 202311
  2. fix one function mistake in case.
  3. remove internal and master from skip list, internal and master should support this case now

How did you do it?

Only check if sai_hash_seed_config_hash_offset_enable exists in config.bcm for 202305 branch, will skip this check for other branches.

How did you verify/test it?

run test_ecmp_sai_value against 202311.

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

ZhaohuiS avatar Jul 11 '24 09:07 ZhaohuiS