sonic-mgmt icon indicating copy to clipboard operation
sonic-mgmt copied to clipboard

Fix core_dump_and_config_check in conftest

Open yaqiangz opened this issue 1 year ago • 1 comments

Description of PR

Summary: Fixes # (issue)

Type of change

  • [x] Bug fix
  • [ ] Testbed and Framework(new/improvement)
  • [ ] Test case(new/improvement)

Back port request

  • [x] 202012
  • [x] 202205
  • [x] 202305
  • [x] 202311
  • [x] 202405

Approach

What is the motivation for this PR?

Currently compare_running_config would return True if the first key / value is equal, which is incorrect. Sample: pre_running_config = { "key_a": "value_a", "key_b": "value_b" } cur_running_config = { "key_a": "value_a", "key_b": "another_value" } After compare "key_a" and find that they are equal, it will return True directly rather than continue to compare "key_b"

How did you do it?

Remove the incorrect return

How did you verify/test it?

Run tests

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

yaqiangz avatar Jul 10 '24 10:07 yaqiangz

Hi, @yaqiangz, the latest commit has some unrelated change

yutongzhang-microsoft avatar Jul 12 '24 05:07 yutongzhang-microsoft

Cherry-pick PR to 202311: https://github.com/sonic-net/sonic-mgmt/pull/13701

mssonicbld avatar Jul 17 '24 17:07 mssonicbld

Cherry-pick PR to 202405: https://github.com/sonic-net/sonic-mgmt/pull/13702

mssonicbld avatar Jul 17 '24 17:07 mssonicbld