sonic-mgmt icon indicating copy to clipboard operation
sonic-mgmt copied to clipboard

Adding port mapping for new Arista Hardware SKUs

Open arista-hpandya opened this issue 1 year ago • 4 comments

Description of PR

Primiarly add support for various Arista 7800R3A SKUs s to port_utils.py. Also one minor tweak config_sonic_basedon_testbed.yml to parameterize asic_topo_config per slot.

Summary:

Type of change

  • [ ] Bug fix
  • [x] Testbed and Framework(new/improvement)
  • [ ] Test case(new/improvement)

Back port request

  • [ ] 202012
  • [ ] 202205
  • [ ] 202305
  • [ ] 202311
  • [x] 202405

Approach

What is the motivation for this PR? How did you do it?

Support all 7800R3A SKU variants

How did you verify/test it?

Validated with sonic-mgmt runs against Arista 7800R3A linecards.

Any platform specific information?

NA

Supported testbed topology if it's a new test case?

NA

Documentation

This is not a new feature and hence does not require a Wiki change.

arista-hpandya avatar Jul 04 '24 18:07 arista-hpandya

The pre-commit check detected issues in the files touched by this pull request. The pre-commit check is a mandatory check, please fix detected issues.

Detailed pre-commit check results: trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
check yaml...............................................................Passed
check for added large files..............................................Passed
check python ast.........................................................Passed
flake8...................................................................Failed
- hook id: flake8
- exit code: 1

ansible/module_utils/port_utils.py:246:14: E127 continuation line over-indented for visual indent
ansible/module_utils/port_utils.py:247:14: E127 continuation line over-indented for visual indent
ansible/module_utils/port_utils.py:248:14: E127 continuation line over-indented for visual indent
ansible/module_utils/port_utils.py:249:14: E127 continuation line over-indented for visual indent
ansible/module_utils/port_utils.py:250:14: E127 continuation line over-indented for visual indent
ansible/module_utils/port_utils.py:254:63: E201 whitespace after '('

flake8...............................................(no files to check)Skipped
check conditional mark sort..............................................Passed

To run the pre-commit checks locally, you can follow below steps:

  1. Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt docker container.
  2. Ensure that the pre-commit package is installed:
sudo pip install pre-commit
  1. Go to repository root folder
  2. Install the pre-commit hooks:
pre-commit install
  1. Use pre-commit to check staged file:
pre-commit
  1. Alternatively, you can check committed files using:
pre-commit run --from-ref <commit_id> --to-ref <commit_id>

mssonicbld avatar Jul 04 '24 18:07 mssonicbld

The pre-commit check is a mandatory. Please help fix it.

wsycqyz avatar Jul 05 '24 00:07 wsycqyz

CLA Signed

The committers listed above are authorized under a signed CLA.

  • :white_check_mark: login: arista-hpandya / name: HP (b05da9bd9f3dfee49ddc083143ac63abd13307ad, 73b3d4518790bb6987bec80b6c0848b3dccf46e4)
  • :white_check_mark: login: ysmanman / name: Song Yuan (b72f783a9236190a755c2b18b8d75b8c395726da)

@arlakshm fyi

kenneth-arista avatar Jul 08 '24 21:07 kenneth-arista

@arlakshm I have addressed the issue with the config change, should we go ahead with the merge? If there are any other concerns/suggestions blocking the merge, let me know and we can discuss them.

arista-hpandya avatar Jul 15 '24 16:07 arista-hpandya

/Azp run Azure.sonic-mgmt

arlakshm avatar Aug 12 '24 16:08 arlakshm

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Aug 12 '24 16:08 azure-pipelines[bot]

@arista-hpandya @kenneth-arista we don't need this in 202205 ?

vmittal-msft avatar Aug 19 '24 20:08 vmittal-msft

@arista-hpandya @kenneth-arista we don't need this in 202205 ?

This is not critical for 202205 since this release is mostly frozen and not accepting test infra changes. Internally, we have this change patched. We would like to merge this change to master to avoid having to carry it internally.

kenneth-arista avatar Aug 19 '24 20:08 kenneth-arista

/Azp run Azure.sonic-mgmt

arlakshm avatar Aug 21 '24 13:08 arlakshm

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Aug 21 '24 13:08 azure-pipelines[bot]

/azpw run Azure.sonic-mgmt

kenneth-arista avatar Sep 18 '24 17:09 kenneth-arista

close and reopen to trigger semgrep

wenyiz2021 avatar Oct 02 '24 17:10 wenyiz2021