snappi_tests: multidut support causes failures in single-dut runs

[rraghav-cisco]

@selldinesh , @isgmano , and @kamalsahu0001

The multidut code is causing issues in single dut runs. The function generate_test_flows() has different arguments in definition and calls. Definition:

Usage:

[kamalsahu0001]

Hi Raghav,

Seems you are having old version of multidut_helper.py file. Below is the latest code from sonic-mgmt. Please copy the latest file and run.

[A screenshot of a computer Description automatically generated]

Regards, Kamal.

From: rraghav-cisco @.> Date: Thursday, April 11, 2024 at 1:14 PM To: sonic-net/sonic-mgmt @.> Cc: Kamal Sahu @.>, Mention @.> Subject: [sonic-net/sonic-mgmt] snappi_tests: multidut support causes failures in single-dut runs (Issue #12416) @selldinesh , @isgmano , and @kamalsahu0001 The multidut code is causing issues in single dut runs. The function generate_test_flows() has different arguments in definition and calls. Definition: Screenshot. 2024-04-11. at. 1. 10. 45. PM. png (view ZjQcmQRYFpfptBannerStart This Message is From an External Sender: Use caution opening files, clicking links or responding to requests.

ZjQcmQRYFpfptBannerEnd

@selldineshhttps://urldefense.com/v3/__https:/github.com/selldinesh__;!!I5pVk4LIGAfnvw!lS7agXzXvwR9e_21-Ee4mnMWL_qou8SsuEZIGopsk1eln4yk2ElsujYp0EWz2k5HC3OhS3-uHjQeX-f5XfC9tMQCi-Q$ , @isgmanohttps://urldefense.com/v3/__https:/github.com/isgmano__;!!I5pVk4LIGAfnvw!lS7agXzXvwR9e_21-Ee4mnMWL_qou8SsuEZIGopsk1eln4yk2ElsujYp0EWz2k5HC3OhS3-uHjQeX-f5XfC9_R-CPbM$ , and @kamalsahu0001https://urldefense.com/v3/__https:/github.com/kamalsahu0001__;!!I5pVk4LIGAfnvw!lS7agXzXvwR9e_21-Ee4mnMWL_qou8SsuEZIGopsk1eln4yk2ElsujYp0EWz2k5HC3OhS3-uHjQeX-f5XfC9CyhAc-A$

The multidut code is causing issues in single dut runs. The function generate_test_flows() has different arguments in definition and calls. Definition: Screenshot.2024-04-11.at.1.10.45.PM.png (view on web)https://urldefense.com/v3/__https:/github.com/sonic-net/sonic-mgmt/assets/58446052/4edf041f-939e-4928-a561-217caad25015__;!!I5pVk4LIGAfnvw!lS7agXzXvwR9e_21-Ee4mnMWL_qou8SsuEZIGopsk1eln4yk2ElsujYp0EWz2k5HC3OhS3-uHjQeX-f5XfC9rc3eAPw$

Usage: Screenshot.2024-04-11.at.1.13.47.PM.png (view on web)https://urldefense.com/v3/__https:/github.com/sonic-net/sonic-mgmt/assets/58446052/23334ad0-7dbf-4f83-9dd0-199332053154__;!!I5pVk4LIGAfnvw!lS7agXzXvwR9e_21-Ee4mnMWL_qou8SsuEZIGopsk1eln4yk2ElsujYp0EWz2k5HC3OhS3-uHjQeX-f5XfC9VakaOxU$

— Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https:/github.com/sonic-net/sonic-mgmt/issues/12416__;!!I5pVk4LIGAfnvw!lS7agXzXvwR9e_21-Ee4mnMWL_qou8SsuEZIGopsk1eln4yk2ElsujYp0EWz2k5HC3OhS3-uHjQeX-f5XfC99H2jqD8$, or unsubscribehttps://urldefense.com/v3/__https:/github.com/notifications/unsubscribe-auth/ANUC6S7NRPJWUFM6GEXNAHTY43VKFAVCNFSM6AAAAABGC6AXZKVHI2DSMVQWIX3LMV43ASLTON2WKOZSGIZTQNJRGA4TSMI__;!!I5pVk4LIGAfnvw!lS7agXzXvwR9e_21-Ee4mnMWL_qou8SsuEZIGopsk1eln4yk2ElsujYp0EWz2k5HC3OhS3-uHjQeX-f5XfC95R1C7Qc$. You are receiving this because you were mentioned.Message ID: @.***>

[rraghav-cisco]

@kamalsahu0001 , thanks for the response. I have pointed out that in 202311 itself - not my own workspace.

[kamalsahu0001]

Ok may be 202311 branch doesn’t have the code from master.

From: rraghav-cisco @.> Date: Thursday, April 11, 2024 at 4:00 PM To: sonic-net/sonic-mgmt @.> Cc: Kamal Sahu @.>, Mention @.> Subject: Re: [sonic-net/sonic-mgmt] snappi_tests: multidut support causes failures in single-dut runs (Issue #12416) @kamalsahu0001 , thanks for the response. I have pointed out that in 202311 itself - not my own workspace. — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned. Message ID:  ZjQcmQRYFpfptBannerStart This Message is From an External Sender: Use caution opening files, clicking links or responding to requests.

ZjQcmQRYFpfptBannerEnd

@kamalsahu0001https://urldefense.com/v3/__https:/github.com/kamalsahu0001__;!!I5pVk4LIGAfnvw!kiHTnonVfAE2vvnphT8bSovlrH-27F1gurKq6H1-f_JNbFxQ9F-kyv8OtpEpS72Jd_9koYcYJjF1l4RS86bfGa4NF3Y$ , thanks for the response. I have pointed out that in 202311 itself - not my own workspace.

— Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https:/github.com/sonic-net/sonic-mgmt/issues/12416*issuecomment-2050688478__;Iw!!I5pVk4LIGAfnvw!kiHTnonVfAE2vvnphT8bSovlrH-27F1gurKq6H1-f_JNbFxQ9F-kyv8OtpEpS72Jd_9koYcYJjF1l4RS86bfEz1A8tQ$, or unsubscribehttps://urldefense.com/v3/__https:/github.com/notifications/unsubscribe-auth/ANUC6S3YSA5SS7QGKH6E6J3Y44IW3AVCNFSM6AAAAABGC6AXZKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANJQGY4DQNBXHA__;!!I5pVk4LIGAfnvw!kiHTnonVfAE2vvnphT8bSovlrH-27F1gurKq6H1-f_JNbFxQ9F-kyv8OtpEpS72Jd_9koYcYJjF1l4RS86bfwRRCAZ8$. You are receiving this because you were mentioned.Message ID: @.***>

[rraghav-cisco]

@kamalsahu0001 : pls check.

[sdszhang]

@rraghav-cisco can you check if the issue still there?

[rraghav-cisco]

Gave a full run on T1, not seeing the issues: ===================================================================================== 22 failed, 98 passed, 46 skipped, 161 warnings, 78 errors in 38006.79s (10:33:26) ====================================================================================== sonic@snappi-202405-sonic-mgmt:/data/tests$