Wait for create acl table/rule message to appear in syslog

[vperumal]

Description of PR

In case of T2 profile, it takes longer time in some cases for create acl table message to appear in syslog. Adding a wait_until proc to check for the message. @abdosi has context of the issue and the issue has been discussed in chassis community meeting.

Summary: Fixes # (issue)

Type of change

• [x] Bug fix
• [ ] Testbed and Framework(new/improvement)
• [ ] Test case(new/improvement)

Back port request

• [ ] 201911
• [ ] 202012
• [x] 202205
• [x] 202305
• [x] 202311

Approach

What is the motivation for this PR?

How did you do it?

How did you verify/test it?

Verified it on T2 profile with Cisco chassis

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

[vperumal]

FYI @abdosi @rajendrat @anamehra

[mssonicbld]

The pre-commit check detected issues in the files touched by this pull request. The pre-commit check is a mandatory check, please fix detected issues.

Detailed pre-commit check results: trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
check yaml...........................................(no files to check)Skipped
check for added large files..............................................Passed
check python ast.........................................................Passed
flake8...................................................................Failed
- hook id: flake8
- exit code: 1

tests/acl/test_acl.py:538:1: E302 expected 2 blank lines, found 1
tests/acl/test_acl.py:538:39: E231 missing whitespace after ','
tests/acl/test_acl.py:539:5: F841 local variable 'cmd' is assigned to but never used
tests/acl/test_acl.py:539:121: E501 line too long (138 > 120 characters)
tests/acl/test_acl.py:540:121: E501 line too long (146 > 120 characters)
tests/acl/test_acl.py:546:1: E302 expected 2 blank lines, found 1
tests/acl/test_acl.py:588:17: F841 local variable 'result' is assigned to but never used

flake8...............................................(no files to check)Skipped
check conditional mark sort..........................(no files to check)Skipped

To run the pre-commit checks locally, you can follow below steps:

1. Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt docker container.
2. Ensure that the pre-commit package is installed:

sudo pip install pre-commit

3. Go to repository root folder
4. Install the pre-commit hooks:

pre-commit install

5. Use pre-commit to check staged file:

pre-commit

6. Alternatively, you can check committed files using:

pre-commit run --from-ref <commit_id> --to-ref <commit_id>

[mssonicbld]

The pre-commit check detected issues in the files touched by this pull request. The pre-commit check is a mandatory check, please fix detected issues.

Detailed pre-commit check results: trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
check yaml...........................................(no files to check)Skipped
check for added large files..............................................Passed
check python ast.........................................................Passed
flake8...................................................................Failed
- hook id: flake8
- exit code: 1

tests/acl/test_acl.py:148:1: E302 expected 2 blank lines, found 1
tests/acl/test_acl.py:257:121: E501 line too long (122 > 120 characters)
tests/acl/test_acl.py:608:21: E128 continuation line under-indented for visual indent
tests/acl/test_acl.py:618:17: F841 local variable 'start_time' is assigned to but never used
tests/acl/test_acl.py:620:68: E502 the backslash is redundant between brackets
tests/acl/test_acl.py:709:21: E128 continuation line under-indented for visual indent
tests/acl/test_acl.py:722:72: E502 the backslash is redundant between brackets

flake8...............................................(no files to check)Skipped
check conditional mark sort..........................(no files to check)Skipped

To run the pre-commit checks locally, you can follow below steps:

1. Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt docker container.
2. Ensure that the pre-commit package is installed:

sudo pip install pre-commit

3. Go to repository root folder
4. Install the pre-commit hooks:

pre-commit install

5. Use pre-commit to check staged file:

pre-commit

6. Alternatively, you can check committed files using:

pre-commit run --from-ref <commit_id> --to-ref <commit_id>

[vperumal]

Hi @abdosi - Made the changes that you requested. Kindly approve and merge

[abdosi]

@yejianquan fir viz.

[yejianquan]

/azp run

[azure-pipelines[bot]]

Azure Pipelines successfully started running 1 pipeline(s).

[arlakshm]

@vperumal, do we know why the delay is seen in master/202405, but the same test works fine in 202205. Will change in the timeout value mask any issue in SONiC/SAI?

[arlakshm]

@kenneth-arista, @ysmanman for viz...

[vperumal]

Hi @arlakshm - This is with respect to the orchagent being busy that we have discussed during chassis community meeting. The message takes a longer time to come in the syslog because orchagent is busy with bulk route download, etc.. The message arrives sometimes just after a couple of seconds after LA check is done.