sonic-mgmt icon indicating copy to clipboard operation
sonic-mgmt copied to clipboard

Add an option to shutdown bgp in fwutil test

Open congh-nvidia opened this issue 1 year ago • 4 comments

Description of PR

Summary: In some lab environment, when the bgp is running, the url of the components is not accessible from the dut. Add this option so we can shutdown bgp when necessary. By default, the bgp is not shutdown, same as the current flow.

Type of change

  • [x] Bug fix
  • [ ] Testbed and Framework(new/improvement)
  • [ ] Test case(new/improvement)

Back port request

  • [ ] 201911
  • [ ] 202012
  • [ ] 202205
  • [ ] 202305
  • [ ] 202311

Approach

What is the motivation for this PR?

Please see the description.

How did you do it?

Add a pytest option.

How did you verify/test it?

Run the test with/without the option set, all passed.

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

congh-nvidia avatar Apr 08 '24 10:04 congh-nvidia

/azpw run

congh-nvidia avatar Apr 09 '24 09:04 congh-nvidia

/AzurePipelines run

mssonicbld avatar Apr 09 '24 09:04 mssonicbld

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Apr 09 '24 09:04 azure-pipelines[bot]

@congh-nvidia thanks for the fix. can you please explain why do we need to stop bgp during fw util tests?

liat-grozovik avatar Apr 16 '24 17:04 liat-grozovik

@prgeor , Can you please review ?

dprital avatar May 06 '24 16:05 dprital