Fixing global_pause attribute and speed typecasting

[selldinesh]

Description of PR

Summary: Fixing the collateral caused by https://github.com/sonic-net/sonic-mgmt/pull/11400 and the speed mode typecasting to int Fixes # (issue)

Type of change

• [ ] Bug fix
• [ ] Testbed and Framework(new/improvement)
• [ ] Test case(new/improvement)

Back port request

• [ ] 201911
• [ ] 202012
• [ ] 202205
• [ ] 202305
• [ ] 202311

Approach

What is the motivation for this PR?

Fixing the collateral caused by https://github.com/sonic-net/sonic-mgmt/pull/11400 and the speed mode typecasting to int

How did you do it?

How did you verify/test it?

added the global_pause attribute to verify_pause_frame_count_dut fixture in multidut_helper file

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

[developfast]

Isn't speed_gbps in multiple of 1000s (since it's in Mb), so it will be typecasted to int? Are you going more granular than that?

[selldinesh]

Isn't speed_gbps in multiple of 1000s (since it's in Mb), so it will be typecasted to int? Are you going more granular than that?

@developfast the speed that was returned was speed_100.0_gbps instead of speed_100_gbps, that is why this change was submitted

[rraghav-cisco]

I applied this diff, but the problem persists.

The DUT counts it as a non-global pause:

root@yy39top-lc4:/home/cisco# show pfc count | head
Last cached time was 2024-04-11T21:41:50.139290
    Port Rx    PFC0    PFC1    PFC2    PFC3    PFC4       PFC5    PFC6    PFC7
-----------  ------  ------  ------  ------  ------  ---------  ------  ------
  Ethernet0       0       0       0       0       0  1,617,164       0       0
  Ethernet8       0       0       0       0       0          0       0       0
 Ethernet16       0       0       0       0       0          0       0       0
 Ethernet24       0       0       0       0       0          0       0       0
 Ethernet32       0       0       0       0       0          0       0       0
 Ethernet40       0       0       0       0       0          0       0       0
 Ethernet48       0       0       0       0       0          0       0       0
root@yy39top-lc4:/home/cisco# 

[developfast]

@rraghav-cisco you don't appear to be running the global pause test? Which test is it? class enable vector is set for priority 5 hence you see pfc frames rx for that priority.

[abdosi]

@rraghav-cisco : can you double check ? It seems same change has been done by you: https://github.com/sonic-net/sonic-mgmt/pull/11694 so this should work .

Please review.

[selldinesh]

Hi @developfast , Request to approve this PR

[mssonicbld]

Cherry-pick PR to 202405: https://github.com/sonic-net/sonic-mgmt/pull/13289