sonic-mgmt icon indicating copy to clipboard operation
sonic-mgmt copied to clipboard

Published 20 hours ago • verified publisher icon sonic-net

Add new skips on mellanox platforms to .yml file

Open mhen1 opened this issue 1 year ago • 11 comments

Description of PR

Summary: Added new skips to tests/common/plugins/conditional_mark/tests_mark_conditions.yaml.

Type of change

  • [ ] Bug fix
  • [x] Testbed and Framework(new/improvement)
  • [ ] Test case(new/improvement)

Back port request

  • [ ] 201911
  • [ ] 202012
  • [ ] 202205
  • [x] 202305
  • [x] 202311

Approach

What is the motivation for this PR?

Add new skips to .yaml file.

How did you do it?

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

mhen1 avatar Mar 26 '24 12:03 mhen1

The pre-commit check detected issues in the files touched by this pull request. The pre-commit check is a mandatory check, please fix detected issues.

Detailed pre-commit check results: trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
check yaml...............................................................Passed
check for added large files..............................................Passed
check python ast.....................................(no files to check)Skipped
flake8...............................................(no files to check)Skipped
flake8...............................................(no files to check)Skipped
check conditional mark sort..............................................Failed
- hook id: check-conditional-mark-sort
- exit code: 1

The entries in tests/common/plugins/conditional_mark/tests_mark_conditions.yaml tests/common/plugins/conditional_mark/tests_mark_conditions_acl.yaml tests/common/plugins/conditional_mark/tests_mark_conditions_drop_packets.yaml tests/common/plugins/conditional_mark/tests_mark_conditions_platform_tests.yaml are not sorted in alphabetic order.

To run the pre-commit checks locally, you can follow below steps:

  1. Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt docker container.
  2. Ensure that the pre-commit package is installed:
sudo pip install pre-commit
  1. Go to repository root folder
  2. Install the pre-commit hooks:
pre-commit install
  1. Use pre-commit to check staged file:
pre-commit
  1. Alternatively, you can check committed files using:
pre-commit run --from-ref <commit_id> --to-ref <commit_id>

mssonicbld avatar Mar 26 '24 12:03 mssonicbld

/azpw run

mhen1 avatar Mar 27 '24 08:03 mhen1

/AzurePipelines run

mssonicbld avatar Mar 27 '24 08:03 mssonicbld

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Mar 27 '24 08:03 azure-pipelines[bot]

@roy-sror

mhen1 avatar Mar 27 '24 11:03 mhen1

/azpw run

mhen1 avatar Apr 10 '24 06:04 mhen1

/AzurePipelines run

mssonicbld avatar Apr 10 '24 06:04 mssonicbld

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Apr 10 '24 06:04 azure-pipelines[bot]

/azp run

wangxin avatar Apr 11 '24 02:04 wangxin

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Apr 11 '24 02:04 azure-pipelines[bot]

@wangxin do you know how to restart or Semgrep only? it is holding from the PR to get in

liat-grozovik avatar Apr 16 '24 16:04 liat-grozovik

@wangxin do you know how to restart or Semgrep only? it is holding from the PR to get in

The Semgrep was auto-inserted by Github. I am not sure how to restart it. Currently this PR has merge conflicts. @mhen1 can you resolve the merge conflicts? A new commit will trigger another round of PR tests. Let's see if that can fix the problem.

wangxin avatar Apr 22 '24 03:04 wangxin

@yxieca Can you please help cherry-pick this PR? Thanks

bingwang-ms avatar May 09 '24 15:05 bingwang-ms

Below tests are passing on Mellanox platform

test_show_platform_fanstatus_mocked
test_thermal_control_fan_status 
test_thermal_control_load_invalid_format_json
test_thermal_control_load_invalid_value_json

Below test is always disabled test_buffer_model_test Please double check.

bingwang-ms avatar May 09 '24 15:05 bingwang-ms

Cherry-pick PR to 202311: https://github.com/sonic-net/sonic-mgmt/pull/12837

mssonicbld avatar May 13 '24 17:05 mssonicbld

Below tests are passing on Mellanox platform

test_show_platform_fanstatus_mocked
test_thermal_control_fan_status 
test_thermal_control_load_invalid_format_json
test_thermal_control_load_invalid_value_json

Below test is always disabled test_buffer_model_test Please double check.

Added a PR updated with the skip reasons of these tests - https://github.com/sonic-net/sonic-mgmt/pull/12939

mhen1 avatar May 22 '24 08:05 mhen1

Hey, I’ve added a new PR, updated with the skip reasons - Updated skip reasons on Mellanox platforms by mhen1 · Pull Request #12939 · sonic-net/sonic-mgmt (github.com)https://github.com/sonic-net/sonic-mgmt/pull/12939. Thanks, Mor Hen

From: bingwang-ms @.> Sent: Thursday, 9 May 2024 18:37 To: sonic-net/sonic-mgmt @.> Cc: Mor Hen @.>; Mention @.> Subject: Re: [sonic-net/sonic-mgmt] Add new skips on mellanox platforms to .yml file (PR #12183)

Below tests are passing on Mellanox platform

test_show_platform_fanstatus_mocked

test_thermal_control_fan_status

test_thermal_control_load_invalid_format_json

test_thermal_control_load_invalid_value_json

Below test is always disabled test_buffer_model_test Please double check.

— Reply to this email directly, view it on GitHubhttps://github.com/sonic-net/sonic-mgmt/pull/12183#issuecomment-2102907516, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BFFHNL4F5DLNI52FKYS3LETZBOJ3NAVCNFSM6AAAAABFI2NE3OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMBSHEYDONJRGY. You are receiving this because you were mentioned.Message ID: @.***>

mhen1 avatar May 22 '24 08:05 mhen1

Hey, Could you please take a look and approve it? Thanks, Mor Hen

From: Mor Hen @.> Sent: Wednesday, 22 May 2024 11:20 To: sonic-net/sonic-mgmt @.>; sonic-net/sonic-mgmt @.>; Xin Wang @.> Cc: Mention @.>; Roy Sror @.> Subject: RE: [sonic-net/sonic-mgmt] Add new skips on mellanox platforms to .yml file (PR #12183)

Hey, I’ve added a new PR, updated with the skip reasons - Updated skip reasons on Mellanox platforms by mhen1 · Pull Request #12939 · sonic-net/sonic-mgmt (github.com)https://github.com/sonic-net/sonic-mgmt/pull/12939. Thanks, Mor Hen

From: bingwang-ms @.@.>> Sent: Thursday, 9 May 2024 18:37 To: sonic-net/sonic-mgmt @.@.>> Cc: Mor Hen @.@.>>; Mention @.@.>> Subject: Re: [sonic-net/sonic-mgmt] Add new skips on mellanox platforms to .yml file (PR #12183)

Below tests are passing on Mellanox platform

test_show_platform_fanstatus_mocked

test_thermal_control_fan_status

test_thermal_control_load_invalid_format_json

test_thermal_control_load_invalid_value_json

Below test is always disabled test_buffer_model_test Please double check.

— Reply to this email directly, view it on GitHubhttps://github.com/sonic-net/sonic-mgmt/pull/12183#issuecomment-2102907516, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BFFHNL4F5DLNI52FKYS3LETZBOJ3NAVCNFSM6AAAAABFI2NE3OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMBSHEYDONJRGY. You are receiving this because you were mentioned.Message ID: @.@.>>

mhen1 avatar Jun 19 '24 10:06 mhen1