sonic-mgmt icon indicating copy to clipboard operation
sonic-mgmt copied to clipboard

Add skip for test_service_warm_restart test by github issue

Open nhe-NV opened this issue 1 year ago • 2 comments

Description of PR

Summary: Add skip for test_service_warm_restart test by github issue: https://github.com/sonic-net/sonic-mgmt/issues/10362 Fixes # (issue)

Type of change

  • [x] Bug fix
  • [ ] Testbed and Framework(new/improvement)
  • [ ] Test case(new/improvement)

Back port request

  • [ ] 201911
  • [ ] 202012
  • [ ] 202205
  • [x] 202305
  • [x] 202311

Approach

What is the motivation for this PR?

How did you do it?

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

nhe-NV avatar Mar 03 '24 14:03 nhe-NV

There is already a skip statement in tests/common/plugins/conditional_mark/tests_mark_conditions_platform_tests.yaml. Can you update the existing one?

bingwang-ms avatar Jul 09 '24 01:07 bingwang-ms

There is already a skip statement in tests/common/plugins/conditional_mark/tests_mark_conditions_platform_tests.yaml. Can you update the existing one?

I see, but you have a PR to revert it right? @bingwang-ms https://github.com/sonic-net/sonic-mgmt/pull/13512

nhe-NV avatar Jul 09 '24 01:07 nhe-NV

There is already a skip statement in tests/common/plugins/conditional_mark/tests_mark_conditions_platform_tests.yaml. Can you update the existing one?

I see, but you have a PR to revert it right? @bingwang-ms #13512

I have closed #13512. Please update your PR. Thanks!

bingwang-ms avatar Jul 22 '24 04:07 bingwang-ms

There is already a skip statement in tests/common/plugins/conditional_mark/tests_mark_conditions_platform_tests.yaml. Can you update the existing one?

I see, but you have a PR to revert it right? @bingwang-ms #13512

I have closed #13512. Please update your PR. Thanks!

Updated

nhe-NV avatar Jul 23 '24 09:07 nhe-NV

Cherry-pick PR to 202311: https://github.com/sonic-net/sonic-mgmt/pull/13776

mssonicbld avatar Jul 23 '24 17:07 mssonicbld

Cherry-pick PR to 202405: https://github.com/sonic-net/sonic-mgmt/pull/13777

mssonicbld avatar Jul 23 '24 17:07 mssonicbld

The change is not required for 202305 as we don't have the skip statement in 202305 branch.

bingwang-ms avatar Jul 23 '24 17:07 bingwang-ms