sonic-mgmt icon indicating copy to clipboard operation
sonic-mgmt copied to clipboard

Add 7060DX5-32 support to test_nhop_group.py

Open bobbymcgonigle opened this issue 1 year ago • 4 comments
trafficstars

Description of PR

Summary: Fixes # (issue) Make test_nhop_group.py pass on 7060dx5-32 by adding support in the test.

Type of change

  • [ ] Bug fix
  • [ ] Testbed and Framework(new/improvement)
  • [x] Test case(new/improvement)

Back port request

  • [ ] 201911
  • [ ] 202012
  • [ ] 202205
  • [x] 202305
  • [x] 202311

Approach

What is the motivation for this PR?

The test does not pass on this Arista SKU

How did you do it?

Manually added th4 support in map and variables

How did you verify/test it?

The test now passes on this SKU

Any platform specific information?

7060DX5-32 Arista

Supported testbed topology if it's a new test case?

Documentation

bobbymcgonigle avatar Mar 02 '24 00:03 bobbymcgonigle

The pre-commit check detected issues in the files touched by this pull request. The pre-commit check is a mandatory check, please fix detected issues.

Detailed pre-commit check results: trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
check yaml...........................................(no files to check)Skipped
check for added large files..............................................Passed
check python ast.........................................................Passed
flake8...................................................................Failed
- hook id: flake8
- exit code: 1

tests/ipfwd/test_nhop_group.py:755:121: E501 line too long (122 > 120 characters)

flake8...............................................(no files to check)Skipped
check conditional mark sort..........................(no files to check)Skipped

To run the pre-commit checks locally, you can follow below steps:

  1. Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt docker container.
  2. Ensure that the pre-commit package is installed:
sudo pip install pre-commit
  1. Go to repository root folder
  2. Install the pre-commit hooks:
pre-commit install
  1. Use pre-commit to check staged file:
pre-commit
  1. Alternatively, you can check committed files using:
pre-commit run --from-ref <commit_id> --to-ref <commit_id>

mssonicbld avatar Mar 02 '24 00:03 mssonicbld

/azp run Azure.sonic-mgmt

StormLiangMS avatar Apr 12 '24 04:04 StormLiangMS

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Apr 12 '24 04:04 azure-pipelines[bot]

The pre-commit check detected issues in the files touched by this pull request. The pre-commit check is a mandatory check, please fix detected issues.

Detailed pre-commit check results: trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
check yaml...........................................(no files to check)Skipped
check for added large files..............................................Passed
check python ast.........................................................Passed
flake8...................................................................Failed
- hook id: flake8
- exit code: 1

tests/ipfwd/test_nhop_group.py:754:121: E501 line too long (122 > 120 characters)

flake8...............................................(no files to check)Skipped
check conditional mark sort..........................(no files to check)Skipped

To run the pre-commit checks locally, you can follow below steps:

  1. Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt docker container.
  2. Ensure that the pre-commit package is installed:
sudo pip install pre-commit
  1. Go to repository root folder
  2. Install the pre-commit hooks:
pre-commit install
  1. Use pre-commit to check staged file:
pre-commit
  1. Alternatively, you can check committed files using:
pre-commit run --from-ref <commit_id> --to-ref <commit_id>

mssonicbld avatar Apr 12 '24 04:04 mssonicbld

/azp run Azure.sonic-mgmt

StormLiangMS avatar Apr 19 '24 04:04 StormLiangMS

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Apr 19 '24 04:04 azure-pipelines[bot]

@prabhataravind @prsunny could you help to review?

StormLiangMS avatar Apr 19 '24 04:04 StormLiangMS

The pre-commit check detected issues in the files touched by this pull request. The pre-commit check is a mandatory check, please fix detected issues.

Detailed pre-commit check results: trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
check yaml...........................................(no files to check)Skipped
check for added large files..............................................Passed
check python ast.........................................................Passed
flake8...................................................................Failed
- hook id: flake8
- exit code: 1

tests/ipfwd/test_nhop_group.py:754:121: E501 line too long (122 > 120 characters)

flake8...............................................(no files to check)Skipped
check conditional mark sort..........................(no files to check)Skipped

To run the pre-commit checks locally, you can follow below steps:

  1. Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt docker container.
  2. Ensure that the pre-commit package is installed:
sudo pip install pre-commit
  1. Go to repository root folder
  2. Install the pre-commit hooks:
pre-commit install
  1. Use pre-commit to check staged file:
pre-commit
  1. Alternatively, you can check committed files using:
pre-commit run --from-ref <commit_id> --to-ref <commit_id>

mssonicbld avatar Apr 19 '24 05:04 mssonicbld

/azp run EasyCLA

StormLiangMS avatar Jun 20 '24 04:06 StormLiangMS

No pipelines are associated with this pull request.

azure-pipelines[bot] avatar Jun 20 '24 04:06 azure-pipelines[bot]

/EasyCLA

StormLiangMS avatar Jun 26 '24 14:06 StormLiangMS

Cherry-pick PR to 202305: https://github.com/sonic-net/sonic-mgmt/pull/13462

mssonicbld avatar Jun 26 '24 14:06 mssonicbld

Cherry-pick PR to 202405: https://github.com/sonic-net/sonic-mgmt/pull/13562

mssonicbld avatar Jul 04 '24 04:07 mssonicbld

Cherry-pick PR to 202311: https://github.com/sonic-net/sonic-mgmt/pull/13563

mssonicbld avatar Jul 04 '24 04:07 mssonicbld