sonic-mgmt
sonic-mgmt copied to clipboard
sonic-net
Increase check bgp session timeout; handle failed tcp connection
Description of PR
Summary: increase check bgp session timeout; handle failed tcp connection
Previously we used the default value for the timeout equal to 30s. While running this test I faced errors because of small timeout occurs rarely, so it was decided to double it(30s -> 60s). Fixes # (issue)
Type of change
- [x] Bug fix
- [ ] Testbed and Framework(new/improvement)
- [ ] Test case(new/improvement)
Back port request
- [ ] 201911
- [ ] 202012
- [ ] 202205
- [x] 202305
Approach
What is the motivation for this PR?
To handle failed TCP connections and adjust bgp session timeout
How did you do it?
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation
The committers listed above are authorized under a signed CLA.
- :white_check_mark: login: illia-kotvitskyi / name: Illia (86466156e95b4630040929da1cd59716c12eb3bb)
![linux-foundation-easycla[bot] avatar](https://avatars.githubusercontent.com/in/17893?v=4 "Published by a pub.dev verified publisher"){kind=small}
The pre-commit check detected issues in the files touched by this pull request. The pre-commit check is a mandatory check, please fix detected issues.
Detailed pre-commit check results:
trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
check yaml...........................................(no files to check)Skipped
check for added large files..............................................Passed
check python ast.........................................................Passed
flake8...................................................................Failed
- hook id: flake8
- exit code: 1
tests/bgp/test_bgp_dual_asn.py:445:1: E302 expected 2 blank lines, found 1
flake8...............................................(no files to check)Skipped
check conditional mark sort..........................(no files to check)Skipped
To run the pre-commit checks locally, you can follow below steps:
- Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt docker container.
- Ensure that the
pre-commitpackage is installed:
sudo pip install pre-commit
- Go to repository root folder
- Install the pre-commit hooks:
pre-commit install
- Use pre-commit to check staged file:
pre-commit
- Alternatively, you can check committed files using:
pre-commit run --from-ref <commit_id> --to-ref <commit_id>
![azure-pipelines[bot] avatar](https://avatars.githubusercontent.com/in/9426?v=4 "Published by a pub.dev verified publisher"){kind=small}
Commenter does not have sufficient privileges for PR 10774 in repo sonic-net/sonic-mgmt
@yxieca how one can restart the semgrep to allow such PR to be available for merge? restarting all the checkers is too much effort.
