sonic-mgmt-framework icon indicating copy to clipboard operation
sonic-mgmt-framework copied to clipboard

Remove dependent package installation.

Open joyas-joseph opened this issue 4 years ago • 1 comments

Signed-off-by: Joyas Joseph [email protected]

- Why I did it Code cleanup.

While analyzing a build failure for sonic-mgmt-framework, it was observed that package installations are happening during the build stage.

05:30:15  make -C src/CLI
05:30:15  make[3]: Entering directory '/sonic/src/sonic-mgmt-framework/src/CLI'
05:30:15  if ! dpkg -l | grep autoconf -c >>/dev/null; then sudo apt-get install autoconf; fi
05:30:15  if ! dpkg -l | grep m4 -c >>/dev/null; then sudo apt-get install m4; fi
05:30:15  if ! dpkg -l | grep libxml2-utils -c >>/dev/null; then sudo apt-get install libxml2-utils; fi
05:30:15  if ! dpkg -l | grep xsltproc -c >>/dev/null; then sudo apt-get install xsltproc; fi
05:30:15  if ! dpkg -l | grep python-lxml -c >>/dev/null; then sudo apt-get install python-lxml; fi
05:30:15  if ! dpkg -l | grep libexpat1-dev -c >>/dev/null; then sudo apt-get install libexpat1-dev; fi
05:30:15  Reading package lists...
05:30:15  Building dependency tree...
05:30:15  Reading state information...
05:30:15  You might want to run 'apt --fix-broken install' to correct these.
05:30:15  The following packages have unmet dependencies:
05:30:15   libnl-route-3-200 : Depends: libnl-3-200 (= 3.4.0-1) but 3.5.0-1 is to be installed
05:30:15   libnl-route-3-dev : Depends: libnl-3-dev (= 3.4.0-1) but 3.5.0-1 is to be installed
05:30:15  E: Unmet dependencies. Try 'apt --fix-broken install' with no packages (or specify a solution).

The required packages are now installed in the sonic-slave docker.

- How I did it Code change.

- How to verify it Build sonic-mgmt-framework package and docker

- Description for the changelog Remove dependent package installation from build stage.

- A picture of a cute animal (not mandatory but encouraged)

joyas-joseph avatar May 21 '20 22:05 joyas-joseph

retest this please

lguohan avatar May 27 '20 19:05 lguohan

please resolve the merge conflicts.

tomek-US avatar May 09 '23 21:05 tomek-US

Already handled through https://github.com/sonic-net/sonic-mgmt-framework/pull/76

joyas-joseph avatar May 11 '23 18:05 joyas-joseph