sonic-linux-kernel
sonic-linux-kernel copied to clipboard
sonic-net
Supermicro_arm64_1G_Switch_G3748_Added: Patch of dts file to support …
This patch is to support new platform, Supermicro 1G arm64 switch G3748 which uses marvel AC5X ASIC. This patch is applied for all arm64 builds and will be effective only for this new platform.
Testing:
- Tested running M0/PTF32 test suites for this new platform.
- Verified image partitions
- Verified uboot and sonic platform functionalities
Hello Saikrishna Yes, once the PR is reviewed and approved it should automatically get merged to master (upstream) I am sure you know that process.So I really don’t completely understand your question. Please help me understand I would be glad to respond.
Yes, once the PR is reviewed and approved it should automatically get merged to master (upstream) I am sure you know that process.So I really don’t completely understand your question. Please help me understand I would be glad to respond.
Hi @SelvaSupermicro,
By upstream, I mean submitting this change into the main Linux kernel. See their contribution page for more details.
Yes, once the PR is reviewed and approved it should automatically get merged to master (upstream) I am sure you know that process.So I really don’t completely understand your question. Please help me understand I would be glad to respond.
Hi @SelvaSupermicro,
By upstream, I mean submitting this change into the main Linux kernel. See their contribution page for more details.
Thanks for the clarifications. These code changes are applicable only for SONiC. Hence we dont want to upstream to main Linux kernel.
From your commit message:
hence will not be upstreamed to main ONL repo
SONiC and ONL are two separate projects for a network operating system. No idea, why you reference ONL.
To ease maintenance of the SONiC Linux kernel repository, you have to sent these patches upstream. Often upstream is also giving you a high quality review, that the SONiC developers/maintainers are not capable of.
Also the devicetree has a lot of commented out lines, that also need to be cleaned up.
From your commit message:
hence will not be upstreamed to main ONL repo
SONiC and ONL are two separate projects for a network operating system. No idea, why you reference ONL.
To ease maintenance of the SONiC Linux kernel repository, you have to sent these patches upstream. Often upstream is also giving you a high quality review, that the SONiC developers/maintainers are not capable of.
Also the devicetree has a lot of commented out lines, that also need to be cleaned up.
From your commit message:
hence will not be upstreamed to main ONL repo
SONiC and ONL are two separate projects for a network operating system. No idea, why you reference ONL.
To ease maintenance of the SONiC Linux kernel repository, you have to sent these patches upstream. Often upstream is also giving you a high quality review, that the SONiC developers/maintainers are not capable of.
Also the devicetree has a lot of commented out lines, that also need to be cleaned up.
Sorry for the ONL reference. I meant to say Linux. Anyway, I have cleaned up the patch to include file that was already committed instead creating new.. Why I don't want to upstream to Linux repo,
- As you can see this patch file depends on many other patches. The other patch files all are in SONiC repo and not in main Linux repo. So they cant apply my patch as it is invalid in that repo.
- Our patch is applicable only for our switch platform running SONiC. So it applicable only for SONiC. It has no value in main Linux.
Sorry for the delay here, could you rebase your changes on top of the master branch, or merge in the current master branch into your branch? This is to resolve the patch conflict in patch/series.
Sorry for the delay here, could you rebase your changes on top of the master branch, or merge in the current master branch into your branch? This is to resolve the patch conflict in
patch/series.
Hi Saikrishna, Thanks for the comment. Now, I have updated patch so that it can be merged with the latest master. Let me know if that is all good!
Hello SaiKrishna, We may need your approve on @SelvaSupermicro new update here? https://github.com/sonic-net/sonic-linux-kernel/pull/373/commits/4aadc9131e6260c2c200b9be5f528a8b41bdb901
Please improve the merge/pull request summary/title.
Echoing this, particularly the title.