sonic-linux-kernel icon indicating copy to clipboard operation
sonic-linux-kernel copied to clipboard

Marvell Arm64 and armada 7020

Open antony-rheneus opened this issue 5 years ago • 8 comments

Marvell Armada A7020 support backported to 4.9.189 Arm64 PCI mmap resource from user space using sysfs Arm64 /proc/dma file access

Signed-off-by: Antony Rheneus [email protected]

antony-rheneus avatar Feb 11 '20 06:02 antony-rheneus

Please retry compilation, as it got failed as below.

LD [M] drivers/net/wireless/realtek/rtlwifi/rtl8723be/rtl8723be.o LD drivers/net/wireless/built-in.o LD drivers/net/built-in.o /var/johnar/workspace/common/linux-kernel-build-pr/linux-4.9.189/Makefile:1026: recipe for target 'drivers' failed make[5]: *** [drivers] Error 2 Makefile:152: recipe for target 'sub-make' failed make[4]: *** [sub-make] Error 2 Makefile:24: recipe for target '__sub-make' failed make[3]: *** [__sub-make] Error 2 make[3]: Leaving directory '/var/johnar/workspace/common/linux-kernel-build-pr/linux-4.9.189/debian/build/build_amd64_none_amd64' debian/rules.real:190: recipe for target 'debian/stamps/build_amd64_none_amd64' failed

antony-rheneus avatar Feb 11 '20 07:02 antony-rheneus

not sure retry will help. check build error below.

/var/johnar/workspace/common/linux-kernel-build-pr/linux-4.9.189/drivers/mtd/nand/raw/cafe_nand.c: In function 'cafe_nand_probe':
/var/johnar/workspace/common/linux-kernel-build-pr/linux-4.9.189/drivers/mtd/nand/raw/cafe_nand.c:656:23: error: 'NAND_OWN_BUFFERS' undeclared (first use in this function)
  cafe->nand.options = NAND_OWN_BUFFERS;
                       ^~~~~~~~~~~~~~~~
/var/johnar/workspace/common/linux-kernel-build-pr/linux-4.9.189/drivers/mtd/nand/raw/cafe_nand.c:656:23: note: each undeclared identifier is reported only once for each function it appears in
/var/johnar/workspace/common/linux-kernel-build-pr/linux-4.9.189/drivers/mtd/nand/raw/cafe_nand.c:727:19: error: invalid application of 'sizeof' to incomplete type 'struct nand_buffers'
     2112 + sizeof(struct nand_buffers) +
                   ^~~~~~
/var/johnar/workspace/common/linux-kernel-build-pr/linux-4.9.189/drivers/mtd/nand/raw/cafe_nand.c:734:12: error: 'struct nand_chip' has no member named 'buffers'
  cafe->nand.buffers = nbuf = (void *)cafe->dmabuf + 2112;
            ^
/var/johnar/workspace/common/linux-kernel-build-pr/linux-4.9.189/drivers/mtd/nand/raw/cafe_nand.c:748:6: error: dereferencing pointer to incomplete type 'struct nand_buffers'
  nbuf->ecccalc = NULL;
      ^~
/var/johnar/workspace/common/linux-kernel-build-pr/linux-4.9.189/drivers/mtd/nand/raw/cafe_nand.c:750:2: error: invalid use of undefined type 'struct nand_buffers'
  nbuf->databuf = (uint8_t *)(nbuf + 1);
  ^~~~
/var/johnar/workspace/common/linux-kernel-build-pr/linux-4.9.189/drivers/mtd/nand/raw/cafe_nand.c:797:18: error: invalid application of 'sizeof' to incomplete type 'struct nand_buffers'
    2112 + sizeof(struct nand_buffers) +
                  ^~~~~~
/var/johnar/workspace/common/linux-kernel-build-pr/linux-4.9.189/drivers/mtd/nand/raw/cafe_nand.c: In function 'cafe_nand_remove':
/var/johnar/workspace/common/linux-kernel-build-pr/linux-4.9.189/drivers/mtd/nand/raw/cafe_nand.c:825:18: error: invalid application of 'sizeof' to incomplete type 'struct nand_buffers'
    2112 + sizeof(struct nand_buffers) +
                  ^~~~~~
/var/johnar/workspace/common/linux-kernel-build-pr/linux-4.9.189/scripts/Makefile.build:315: recipe for target 'drivers/mtd/nand/raw/cafe_nand.o' failed
make[9]: *** [drivers/mtd/nand/raw/cafe_nand.o] Error 1
make[9]: *** Waiting for unfinished jobs....
  CC [M]  drivers/media/pci/mantis/mantis_vp2040.o
/var/johnar/workspace/common/linux-kernel-build-pr/linux-4.9.189/drivers/mtd/nand/raw/nandsim.c:43:28: fatal error: linux/sched/mm.h: No such file or directory
 #include <linux/sched/mm.h>
                            ^
compilation terminated.

lguohan avatar Feb 11 '20 14:02 lguohan

please identify the upstream commit id and the start linux version that introduce this patch.

check below for example

https://github.com/Azure/sonic-linux-kernel/blob/master/patch/linux-4.13-thermal-intel_pch_thermal-Fix-enable-check-on.patch

lguohan avatar Feb 12 '20 15:02 lguohan

i can see quite a few patches for armada 7020 is in 4.19. can you check when armada 7020 is fully supported in linux kernel. since we are moving to 4.19 in this release. maybe we can support this 7020 in the coming 4.19 release instead of back port this to 4.9 release. there are quite a few changes related to general function which can impact other platforms. I have concerns to back port this patch to 201911 release.

lguohan avatar Feb 14 '20 17:02 lguohan

i can see quite a few patches for armada 7020 is in 4.19. can you check when armada 7020 is fully supported in linux kernel. since we are moving to 4.19 in this release. maybe we can support this 7020 in the coming 4.19 release instead of back port this to 4.9 release. there are quite a few changes related to general function which can impact other platforms. I have concerns to back port this patch to 201911 release.

From 4.14, Armada 7020 is fully supported and upstreamed. I agree with you, as it is platform dependent and not a generic patch, to would affect or break when we do version migration.

antony-rheneus avatar Feb 17 '20 05:02 antony-rheneus

great, then I will skip these patches for 4.9 kernel. We plan to get to debian buster 4.19 for sonic 202006 release

lguohan avatar Mar 20 '20 04:03 lguohan

great, then I will skip these patches for 4.9 kernel. We plan to get to debian buster 4.19 for sonic 202006 release

Thanks, I will keep this PR open till we move to latest kernel, as we maintain list open PRs to patch while building SONIC image for Marvell.

antony-rheneus avatar Mar 20 '20 05:03 antony-rheneus

/easycla

jarias-lfx avatar Jul 19 '23 19:07 jarias-lfx