sonic-buildimage icon indicating copy to clipboard operation
sonic-buildimage copied to clipboard

Add SAG SONiC Yang

Open superchild opened this issue 4 years ago • 11 comments

Why I did it

For static anycast gateway feature, add related yang model. Refer to SAG HLD#837

Signed-off-by: Jimi Chen [email protected]

How I did it

  • Defined sonic-static-anycast-gateway.yang model, and modify sonic-vlan.yang for new added field.
  • Add sonic-yang-model/sonic-yang-mgmt unit test case

How to verify it

  • build sonic_yang_models-1.0-py3-none-any.whl /sonic_yang_mgmt-1.0-py3-none-any.whl successfully

Which release branch to backport (provide reason below if selected)

  • [ ] 201811
  • [ ] 201911
  • [ ] 202006
  • [ ] 202012
  • [ ] 202106

Description for the changelog

A picture of a cute animal (not mandatory but encouraged)

superchild avatar Oct 20 '21 07:10 superchild

@lguohan Could you please help to review the code? The related CLI sonic-utilities#1887 code change doesn't have reviewer yet, could you please help to assign someone to review? Thanks.

superchild avatar Oct 28 '21 01:10 superchild

@venkatmahalingam please help to review the updated version, thanks.

superchild avatar Nov 04 '21 01:11 superchild

@venkatmahalingam @lguohan Can you please help to check and review? Thanks.

superchild avatar Jan 03 '22 05:01 superchild

@qiluo-msft @venkatmahalingam Could you please help to review the change?

superchild avatar Jan 27 '22 08:01 superchild

@qiluo-msft @venkatmahalingam @lguohan Could you please help to review again? Thanks.

superchild avatar May 06 '22 13:05 superchild

Could you merge latest master? It will also retrigger the PR checkers.

qiluo-msft avatar May 06 '22 21:05 qiluo-msft

@superchild can you please sign-off the EasyCLA? This merge is blocked by it. Thanks.

zhangyanzhao avatar Feb 01 '23 07:02 zhangyanzhao

@zhangyanzhao I already signed the EasyCLA, there're some conflicts existed. I'll fix the conflicts soon.

superchild avatar Feb 13 '23 03:02 superchild

@zhangyanzhao Conflict is resolved, I think it needs reviewer to approve running workflows.

superchild avatar Feb 13 '23 05:02 superchild

@venkatmahalingam i see you had comments, can you please review following comments handling so i can go a head and merge

liat-grozovik avatar Apr 11 '24 16:04 liat-grozovik

@superchild please handle conflicts

liat-grozovik avatar Apr 11 '24 16:04 liat-grozovik

@liat-grozovik
I don't work on this project anymore and don't have related build machine to test.
I'll suggest someone can help to finish this or send the other PR.

superchild avatar Apr 18 '24 13:04 superchild