sonic-buildimage icon indicating copy to clipboard operation
sonic-buildimage copied to clipboard
verified publisher icon sonic-net

[Arista] Update platform library submodules

Open Staphylo opened this issue 1 year ago • 4 comments

Why I did it

  • Add support for new psus
  • Add support for new fan modules
  • Report fan information from all fabric cards
  • Fix psud warning due to invalid pmbus threshold reported
  • Disable lpmode for chassis
Work item tracking
  • Microsoft ADO (number only):

How I did it

Updated our platform driver submodules

How to verify it

Changes validated against sonic-mgmt 202405 and master

Description for the changelog

Update Arista platform library submodules

Staphylo avatar Oct 24 '24 11:10 Staphylo

@arlakshm @wenyiz2021 for viz

kenneth-arista avatar Oct 29 '24 17:10 kenneth-arista

Hi @Staphylo, @kenneth-arista, do we need the change to disable lpmode for chassis in the platform driver? I thought the change is done in xcvr to fix the lpmode issue on the chassis?

arlakshm avatar Oct 29 '24 17:10 arlakshm

Hi @Staphylo, @kenneth-arista, do we need the change to disable lpmode for chassis in the platform driver? I thought the change is done in xcvr to fix the lpmode issue on the chassis?

The change to disable lpmode for chassis in the platform library is a temporary work around while the fix to xcvrd is being worked on.

kenneth-arista avatar Oct 30 '24 06:10 kenneth-arista

Hi @Staphylo, @kenneth-arista, do we need the change to disable lpmode for chassis in the platform driver? I thought the change is done in xcvr to fix the lpmode issue on the chassis?

The change to disable lpmode for chassis in the platform library is a temporary work around while the fix to xcvrd is being worked on.

@Staphylo @kenneth-arista can we avoid hacking here? Looks like you don't want to own the change on Xcvrd code

prgeor avatar Nov 05 '24 01:11 prgeor

I have opened PR #20929 to supersede this PR; it includes a revert for the "Disable lpmode on chassis" commit that was included in this PR

patrickmacarthur avatar Nov 26 '24 23:11 patrickmacarthur

I have opened PR #20929 to supersede this PR; it includes a revert for the "Disable lpmode on chassis" commit that was included in this PR

please close this one then, thanks.

rlhui avatar Nov 27 '24 18:11 rlhui

I have opened PR #20929 to supersede this PR; it includes a revert for the "Disable lpmode on chassis" commit that was included in this PR

please close this one then, thanks.

This is Samuel's PR so I don't have permissions to close it.

patrickmacarthur avatar Nov 27 '24 18:11 patrickmacarthur

I have opened PR #20929 to supersede this PR; it includes a revert for the "Disable lpmode on chassis" commit that was included in this PR

please close this one then, thanks.

This is Samuel's PR so I don't have permissions to close it.

@Staphylo would you be closing this PR? thanks.

rlhui avatar Nov 27 '24 22:11 rlhui

Closing as discussed

Staphylo avatar Dec 02 '24 16:12 Staphylo